Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simply support initZygote #7

Closed
wants to merge 1 commit into from
Closed

Simply support initZygote #7

wants to merge 1 commit into from

Conversation

ApeaSuperz
Copy link

The data structure of IXposedHookZygoteInit.StartupParam is very simple, therefor data wrapper is not created.

Been handled together, relax superclass restriction of proxy class (hook entry) to meet the complex customization needs of users.

@fankes
Copy link
Collaborator

fankes commented Apr 11, 2022

Well
Thanks for your pull request.
Some of the suggestions are good, and I will make some changes.
The method of adding initZygote is not in line with the current overall implementation principle, and I will manually adjust this function later.
This functionality was later packaged into a new wrapper implementation, rather than simply adding a portal, which was not as expected, and I wanted to take over XResource and StartUp completely.

@fankes fankes added the enhancement New feature or request label Apr 11, 2022
@fankes
Copy link
Collaborator

fankes commented Apr 11, 2022

Thank you for the improvement of some functions of ksp, the StartUp function will be added in the later stage according to the demand.

@fankes fankes closed this Apr 11, 2022
@ApeaSuperz
Copy link
Author

ApeaSuperz commented Apr 11, 2022

XModuleResources is a important part of Xposed, especially when adding a custom view into hooked apps with extra class (for example, use com.google.android.material that hooked app not include). It is easy to see a large module or a module mainly targets ui-hook to use it and a well-developed hook API should not have no support for it.

YukiHookAPI is a promising hook API written in Kotlin. However, if there is a delay in supporting resources-related hooks, it will force users to move to other hook APIs, which is a pity.

@fankes
Copy link
Collaborator

fankes commented Apr 11, 2022

At present, the number of people using it is still relatively small, and my time is relatively limited.
Later I will gradually consider the support, thank you for your feedback.

@fankes
Copy link
Collaborator

fankes commented Apr 11, 2022

But something I don't know.
Are you a Chinese people? I saw your Code Comment writting in Chinese, are they both from Google Translation yet?

@ApeaSuperz
Copy link
Author

But something I don't know. Are you a Chinese people? I saw your Code Comment writting in Chinese, are they both from Google Translation yet?

一般来说,我在编程时偏好使用英语,不过在与他人协同时我会尊重项目原有的编码风格,所以使用了中文注释。

@fankes
Copy link
Collaborator

fankes commented Apr 11, 2022

But something I don't know. Are you a Chinese people? I saw your Code Comment writting in Chinese, are they both from Google Translation yet?

一般来说,我在编程时偏好使用英语,不过在与他人协同时我会尊重项目原有的编码风格,所以使用了中文注释。

这样来说,我英语不是非常的好,所以有些地方还有语法错误也请多多包涵。
另外这个项目目前用的人比较少,我也是没有精力一次性做完的,有更多的人合作会更好。
你添加的入口实现类大概不符合这个框架的预期设计风格,这个我打算等后面人稍微多一点的时候,按需求重新设计这块,谢谢你的贡献,这个在作考虑中。
另外,后面大概会增加英语的翻译版本和注释,目前为了符合国人使用习惯,暂时使用中文。

@fankes fankes added fixed This bug was fixed and removed enhancement New feature or request fixed This bug was fixed labels May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants