Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple languages support? #94

Closed
ojarux opened this issue Apr 20, 2023 · 6 comments · Fixed by #95
Closed

multiple languages support? #94

ojarux opened this issue Apr 20, 2023 · 6 comments · Fixed by #95

Comments

@ojarux
Copy link

ojarux commented Apr 20, 2023

I think it is a very useful add-on. However, This add-on seems to be limited to single-byte characters.

  1. Is it possible to support multiple languages?
    image

  2. It would be useful to be able to open a new page without closing the search results with a middle click.
    Thanks!

@ojarux
Copy link
Author

ojarux commented Apr 21, 2023

Almost solved,

  1. I can use double-byte character in "PRECISE" mode
  2. Ctrl+Enter works well in this situation

@ojarux ojarux closed this as completed Apr 21, 2023
@Fannon
Copy link
Owner

Fannon commented Apr 21, 2023

Hi @ojarux : Could you try this option?
The problem is that the fuzzy search library by default does not work well with CJK languages.
You can also switch to precise search only, it should handle this situation fine (and if not, please report so I can look into how to fix it :) )

# make CJK chars work for fuzzy search
uFuzzyOptions:
  interSplit: (p{Unified_Ideograph=yes})+

See also this issue: #87

@Fannon
Copy link
Owner

Fannon commented Apr 21, 2023

I've seen that you use the hybrid search mode. Does it give you any benefits?
It was added at a time when the fuzzy search was not giving as relevant results as nowadays, so combining it with precise seemed a good workaround. But now fuzzy search got better and I'm not sure whether it makes sense to keep hybrid around.

@ojarux
Copy link
Author

ojarux commented Apr 21, 2023

Thank you for your prompt reply.
As I already mentioned, I was able to avoid the problem by setting the search mode to "PRECISE".
I also tried uFuzzyOptions and it works, however the result with or without fuzzy search are the same.
I think it is the best of the similar add-ons!
If I may make a request, it would be great if the display space could be widened and the font size could be changed to improve the listability.

@Fannon
Copy link
Owner

Fannon commented Apr 21, 2023

Thanks for the kind words and feedback!

Good point about increasing size in general. I'll think about that how that can be done best, as a browser extensions popup are not really "responsive" like you can make a website responsive. Right now it's a very fixed layout and it would be some effort to customize that. But I can think about making it generally a bit bigger.

@Fannon
Copy link
Owner

Fannon commented Apr 29, 2023

I've reopened this issue because for the average user, it's unrealistic they'll look for and apply a custom setting to fix this.

But I also didn't want to apply the ideagraph setting generally, so I created a PR where this is only added when necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants