Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateRestorePoint enables Restore points even when disabled #124

Closed
Cubox opened this issue Jan 22, 2021 · 5 comments
Closed

CreateRestorePoint enables Restore points even when disabled #124

Cubox opened this issue Jan 22, 2021 · 5 comments

Comments

@Cubox
Copy link

Cubox commented Jan 22, 2021

Hi,

It seems that the Wrapper will always output CreateRestorePoint in the generated powershell. Since I manually disable those, I don't want restore points created.
The issue is that Sophia will enable restore points again, https://github.com/farag2/Windows-10-Sophia-Script/blob/2ce62a3cf64b859814a30e435df086d4b170aa6d/Sophia/Sophia.psm1#L130

Could Sophia either not overwrite the previously configured restore point, or the Wrapper let us pick if we want to create a restore point?
Maybe there is an option to do this already, and I'm missing it...

Running 21.01.2021

@farag2
Copy link
Owner

farag2 commented Jan 22, 2021

Did you disable this function?
https://github.com/farag2/Windows-10-Sophia-Script/blob/2ce62a3cf64b859814a30e435df086d4b170aa6d/Sophia/Sophia.ps1#L88

Not at home. Replying via phone.

@Cubox
Copy link
Author

Cubox commented Jan 22, 2021

The wrapper generates this script. Sure, you can comment it, but if you're not paying attention, you don't see Sophia enabling system restore points "behind your back"

@farag2
Copy link
Owner

farag2 commented Jan 22, 2021

Hm, I'll update this function.

@Cubox
Copy link
Author

Cubox commented Jan 22, 2021

Thanks!
Love the script, I'll contribute some functions from tips I apply on my installs

@farag2
Copy link
Owner

farag2 commented Feb 4, 2021

@farag2 farag2 closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants