Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A Wrong Localization Name #196

Closed
flashercs opened this issue Jun 16, 2021 · 3 comments
Closed

A Wrong Localization Name #196

flashercs opened this issue Jun 16, 2021 · 3 comments

Comments

@flashercs
Copy link
Contributor

The Chinese Localization Folder Name Should be zh-CN, not cn-CN.
The command [System.Globalization.CultureInfo]::GetCultureInfo("cn-CN") gets a cultureinfo of Unknown Locale (cn-CN);and [System.Globalization.CultureInfo]::GetCultureInfo("zh-CN") gets the correct cultureinfo of Chinese (Simplified, PRC).
@farag2
Copy link
Owner

farag2 commented Jun 16, 2021

Nice. I didn't know)

@farag2
Copy link
Owner

farag2 commented Jun 16, 2021

What about the translation quality? May be you can inprove it?

@flashercs
Copy link
Contributor Author

You do a good job. The translation is very good, I just modified a few words to make it more accurate. I have created a pull request.

@farag2 farag2 closed this as completed Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@farag2 @flashercs