Health rolling negative

[FarazzShaikh]

Problem

Health is being subtracted from even after its zero. Shouldn't be a problem after death is implement but is a bug in current release.

Bugged Lines

https://github.com/F28WP-Dubai-Group-6/LunarLander/blob/7d6d86f3c8bd8642cefc78ddaf18e783d5333d45/server/src/Game/Collision.js#L33

Potential Solution

Guard the damage routine with an if block. Only allow subtraction of damage if the health is greater than 0.

[KishanBapodra]

i think i did do it in prev version willo fix this

…

On Thu, Nov 5, 2020 at 5:33 PM Faraz Shaikh ***@***.***> wrote: Problem Health is being subtracted from even after its zero. Shouldn't be a problem after death is implement but is a bug in current release. Bugged Lines https://github.com/F28WP-Dubai-Group-6/LunarLander/blob/7d6d86f3c8bd8642cefc78ddaf18e783d5333d45/server/src/Game/Collision.js#L33 Potential Solution Guard the damage routine with an if block. Only allow subtraction of damage if the health is greater than 0. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#56>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOKF3KZNYGRFDPEACVAQMBDSOKSTNANCNFSM4TLLZZEQ> .