Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max block validity in Deal #187

Open
h4sh3d opened this issue Dec 3, 2021 · 1 comment
Open

Add max block validity in Deal #187

h4sh3d opened this issue Dec 3, 2021 · 1 comment
Assignees
@h4sh3d
Labels
discussion enhancement New feature or request
Milestone
v0.7.0

Comments

@h4sh3d
Copy link
Member

h4sh3d commented Dec 3, 2021

This should allow the same offer to have different ID each seconds, this is a temporary fix. The offer should evolve more later.
@h4sh3d h4sh3d self-assigned this Dec 7, 2021
@h4sh3d
Copy link
Member Author

h4sh3d commented Jun 7, 2022

Latest discussions about this lean toward a block height validity for the lock transaction, after that height the offer is considered not valid anymore and can be dropped.

@h4sh3d h4sh3d added enhancement New feature or request discussion labels Jun 17, 2022
@h4sh3d h4sh3d changed the title Add creation timestamp in Offer Add max block validity in Offer Jul 11, 2022
@h4sh3d h4sh3d added this to the v0.6.0 milestone Jul 11, 2022
@h4sh3d h4sh3d modified the milestones: v0.6.0, v0.7.0 Aug 29, 2022
@h4sh3d h4sh3d changed the title Add max block validity in Offer Add max block validity in Deal Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h4sh3d h4sh3d

Labels
discussion enhancement New feature or request
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
1 participant
@h4sh3d