Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: smart contract wallet verifications #1437

Closed
horsefacts opened this issue Sep 28, 2023 · 1 comment
Closed

feat: smart contract wallet verifications #1437

horsefacts opened this issue Sep 28, 2023 · 1 comment
Assignees
@horsefacts
Labels
s-started Being worked on t-feat Add a new feature or protocol improvement
Milestone
v1.6.0

Comments

@horsefacts
Copy link
Contributor

horsefacts commented Sep 28, 2023 •
edited

What is the feature you would like to implement?
Extend verifications to support EIP-1271 signatures from smart contract wallets. See also: farcasterxyz/protocol#109

Why is this feature important?
Support linking smart contract wallets and other non-EOA accounts to Farcaster identities.

Will the protocol spec need to be updated??
Yes: Section 1.5 — Verifications
@horsefacts horsefacts added the t-feat Add a new feature or protocol improvement label Sep 28, 2023
@horsefacts horsefacts added this to the v1.6.0 milestone Sep 28, 2023
@horsefacts horsefacts self-assigned this Sep 28, 2023
@github-actions github-actions bot added the s-triage Needs to be reviewed, designed and prioritized label Sep 28, 2023
@horsefacts horsefacts added s-started Being worked on and removed s-triage Needs to be reviewed, designed and prioritized labels Oct 3, 2023
@horsefacts horsefacts modified the milestones: v1.6.0, vNext Oct 5, 2023
@sds
Copy link
Member

sds commented Mar 7, 2024

Implemented in #1449.

@sds sds closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@horsefacts horsefacts

Labels
s-started Being worked on t-feat Add a new feature or protocol improvement
Projects
farcaster
Status: No status
Milestone
v1.6.0
Development

No branches or pull requests
2 participants
@sds @horsefacts