Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace schema with message type #91

Closed
pfletcherhill opened this issue Aug 26, 2022 · 1 comment
Closed

feat: replace schema with message type #91

pfletcherhill opened this issue Aug 26, 2022 · 1 comment
Assignees
Labels
t-docs Add or update documentation t-feat Add a new feature or protocol improvement
Milestone

Comments

@pfletcherhill
Copy link
Contributor

pfletcherhill commented Aug 26, 2022

What is the feature you would like to implement?
Replace schema inside message body with a type field inside message data. The type should be a 16-bit number.

Why is this feature important?
Right now message type is inferred from the format of the message and the schema field. We should be able to quickly and more directly parse a message and know what set to route it to for merging.

Will the protocol spec need to be updated??
Yes, the protocol spec should include the table of supported message types with each version.

How should this feature be built? (optional)
Here is an initial list of message types:

  • CastShort
  • CastRecast
  • CastRemove
  • ReactionAdd
  • ReactionRemove
  • FollowAdd
  • FollowRemove
  • VerificationEthereumAddress
  • VerificationRemove
  • SignerAdd
  • SignerRemove

And here are potential future message types:

  • Metadata
  • CastLong
  • CastPoll
  • CastEvent
  • CastRSVP
  • GroupInviteAdd
  • GroupInviteGrant
  • GroupInviteAccept
  • VerificationBitcoinAddress
  • VerificationTwitter
  • VerificationDomain
@pfletcherhill pfletcherhill added t-docs Add or update documentation t-feat Add a new feature or protocol improvement labels Aug 26, 2022
@pfletcherhill pfletcherhill added this to the v2.0.0 milestone Aug 26, 2022
@pfletcherhill pfletcherhill self-assigned this Aug 26, 2022
@pfletcherhill
Copy link
Contributor Author

Implemented #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-docs Add or update documentation t-feat Add a new feature or protocol improvement
Projects
None yet
Development

No branches or pull requests

1 participant