Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variable warning is polluting the Serial Console :) 10.1.3 #1225

Closed
jsimmonds2 opened this issue Jul 26, 2020 · 9 comments
Closed

Unused variable warning is polluting the Serial Console :) 10.1.3 #1225

jsimmonds2 opened this issue Jul 26, 2020 · 9 comments

Comments

@jsimmonds2
Copy link
Contributor

image

@RickCarlino
Copy link
Contributor

I take the blame for this one @jsimmonds2 . While implementing the filter groups / group iteration feature, I was having issues with a part of the CSVM and worked around it temporarily. Definitely a bug, but the warning does not point to a significant problem, rather it points to some corner cutting on my part. I hope I can fix this in the upcoming v3 MOVE TO block.

@jsimmonds2
Copy link
Contributor Author

jsimmonds2 commented Jul 27, 2020

the blame

"blame" . . What's that ? :-)

Can CircleCI catch the console stderr stream ? Or compile time warnings like this ?

@RickCarlino
Copy link
Contributor

😛 I need to do a patch release today anyway to un-bork an unrelated issue. I will include a simple fix for this in 10.1.4.

@jsimmonds2
Copy link
Contributor Author

Ooops . . got a New one now ( only on Serial Console stderr , not SSH ) 10.1.4 commit 1c5ef14

image

@jsimmonds2
Copy link
Contributor Author

Hello @RickCarlino ! Has this one ( above ) been cleaned up yet ? :) Thanks !

@RickCarlino
Copy link
Contributor

@jsimmonds2 It's pretty low priority given the other things that are going on this week, but I will need to go in there next week when writing the V3 MOVE block that's coming up.

Did the fix make it worse? I can remove it if that's the case.

@jsimmonds2
Copy link
Contributor Author

jsimmonds2 commented Aug 5, 2020

Thanks @RickCarlino . No problems 😅 It's not worse after the recent fix, just a different unused variable.

Rarely use the Console device, but it's the only way I know of to see the stdout and stderr streams of the BEAM.

P.S. I heard today ( in Australia ) that Chicago is recently a SARS-COV-2 "hot-spot" ! Wear a mask and look after yourself 👍

@RickCarlino
Copy link
Contributor

@jsimmonds2 Found a fix while working on unrelated features. The fix is in bb077b1 and will be deployed as part of v11.0.0

@jsimmonds2
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants