Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work. #2

Closed
stoopered opened this issue Feb 5, 2020 · 7 comments
Closed

Does not work. #2

stoopered opened this issue Feb 5, 2020 · 7 comments

Comments

@stoopered
Copy link

When I publish the html, it shows the html code instead of the page.

Screen Shot 2020-02-05 at 9 48 02 AM

Should be
Screen Shot 2020-02-05 at 9 49 36 AM

@xximjasonxx
Copy link
Collaborator

I will take a look at this as soon as I can. Thanks for letting me know

@xximjasonxx
Copy link
Collaborator

One thing I did notice while looking through this, apart from the HTML not rendering, your source does have local references (styles.css for example) - this will break once the rendering process is fixed since the task only publishes the HTML and not the backing resources.

@stoopered
Copy link
Author

Thanks for the quick response. I removed the stylesheet reference, and it still does not work.

I was looking at the Microsofts example of build results enhancer, and when I replace their html with my doc, it does display, I do have to include their scripts section at the top of my html. The problem with theirs is that I am unable to select my own file at build time, and I do not know enough about building these tasks yet to make it usable.

I could send you my HTML if you think that would help. I am using the free Aqua to scan my docker and generate the html.

https://github.com/microsoft/vsts-extension-samples/tree/master/build-results-enhancer

@xximjasonxx
Copy link
Collaborator

I did confirm with some other HTML that this is not working. I will try to find time over the weekend to look at what broke. Apologies that I cannot look at it any sooner

@stoopered
Copy link
Author

No problem, thanks for your help!

@xximjasonxx
Copy link
Collaborator

I pushed an updated version (v1.2.2) this evening. My testing shows it is rendering HTML and images in both build and release cases. However, only in Build will it add a new tab, in Release it appends itself to the release instance.

Tip: In both cases, look at stripping the non viewable portion of the HTML (that is the head section mainly, you also do not need the body tag). Hope this works for you now. Cheers

@stoopered
Copy link
Author

Thanks I will check it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants