Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oudated usage of run_farseer in main.py #14

Closed
joaomcteixeira opened this issue Sep 2, 2017 · 3 comments
Closed

oudated usage of run_farseer in main.py #14

joaomcteixeira opened this issue Sep 2, 2017 · 3 comments
Assignees
Labels

Comments

@joaomcteixeira
Copy link
Member

in main.py it reads

from current.farseermain import read_user_variables, run_farseer
        fsuv, cwd = read_user_variables(spectrum_path)
        run_farseer('{}/spectra'.format(cwd), fsuv)

run_farseer() from farseermain.py now takes only one argument, fsuv, as returned from read_user_variables() that takes only the path argument

@joaomcteixeira
Copy link
Member Author

could you tell me which value would take
spectrum_path in line 105 of main.py ?
is it ..../spectra ?

@skinnersp
Copy link
Collaborator

skinnersp commented Sep 2, 2017

no, it's the path where the spectra folder should be created. In current.setup_farseer_calculation.py, the create_directory_structure function takes the path and appends /spectra/ to it before creating the structure that farseer requires. We can of course change this so that the path has to end in spectra, it's a simple change to line 4 of current.setup_farseer_calculation.py,

@joaomcteixeira
Copy link
Member Author

no need to change anything. is already compatible with read_user_variables function call.
I have created a branch and solve this in the branch, is very little changes.

joaomcteixeira added a commit that referenced this issue Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants