Skip to content
This repository has been archived by the owner on Aug 15, 2021. It is now read-only.

Rounded corners to bottom sheets #5

Closed
fartem opened this issue Feb 14, 2020 · 9 comments
Closed

Rounded corners to bottom sheets #5

fartem opened this issue Feb 14, 2020 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fartem
Copy link
Owner

fartem commented Feb 14, 2020

Add rounded corners to bottoms sheets.

@fartem fartem added enhancement New feature or request good first issue Good for newcomers labels Feb 14, 2020
@alirezanazari
Copy link
Contributor

Hi @fartem may i help you to solve this issue?

@fartem
Copy link
Owner Author

fartem commented Mar 5, 2020

Hi @fartem may i help you to solve this issue?

Hi. Yes.

@alirezanazari
Copy link
Contributor

Dear @fartem there are problem in syncing gradle . can you help me ?

Build file '/Informations/project/Git/crypto-tracker/build.gradle' line: 16
Plugin [id: 'io.gitlab.arturbosch.detekt', version: '1.2.2'] was not found in any of the following sources:

@fartem
Copy link
Owner Author

fartem commented Mar 6, 2020

@alirezanazari I'm updated detekt plugin version to 1.6.0 and tested downloading and build on my PC. You can get changes from the last commit.

Some notes about working with the app:

  1. you can use debug flavor if you cannot have a CoinMarketCap account (flavors changing in Android Studio);
  2. in .travis.yml you can find all Gradle tasks for running all needed checks.

@alirezanazari
Copy link
Contributor

Dear @fartem this issue fixed and i send PR .
#6

i saw problems in theme switching if you want i fixed theme which switching smothely .

@fartem
Copy link
Owner Author

fartem commented Mar 6, 2020

Dear @alirezanazari It would be great to fix theme switching

@alirezanazari
Copy link
Contributor

ok . please create new issue and i fix it as soon as possible

@fartem
Copy link
Owner Author

fartem commented Mar 6, 2020

@alirezanazari Can you tell me about theme switching problems?

@fartem fartem closed this as completed Mar 6, 2020
@alirezanazari
Copy link
Contributor

Yes sure
you should use single activity pattern and based on your code you have one fragment and used this pattern , what you need is update preferences and detach/attach your fragment manager and your theme updated at run time without closing activity .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants