Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaining show case views #17

Closed
MFlisar opened this issue Mar 26, 2017 · 5 comments
Closed

Chaining show case views #17

MFlisar opened this issue Mar 26, 2017 · 5 comments

Comments

@MFlisar
Copy link
Contributor

MFlisar commented Mar 26, 2017

Is this possible? There is no listener for on showcase closed (only for the animation).

Would be nice to have at least a callback which can be setup via the builder

@faruktoptas
Copy link
Owner

It is possible if you set your own enter/exit animations. But if you use default animations it is not possible for now.
It can be implemented easily. I'm open to contributions :)

@MFlisar
Copy link
Contributor Author

MFlisar commented Mar 26, 2017

Already done ;-) at least the listener callback...

@MFlisar
Copy link
Contributor Author

MFlisar commented Mar 26, 2017

I would make a simple FancyShowCaseQueue (do you have a better naming idea?) like following:

new FancyShowCaseQueue()
    .add(FancyShowCaseView1)
    .add(FancyShowCaseView2)
    .add(FancyShowCaseView3)
    .show();

Internally I would set or wrap the DismissListener and show the FancyShowCaseViews one after another. Or do you prefer something else?

@faruktoptas
Copy link
Owner

I think this approach is ok. Creating a simple queue will solve this. This is a common usage.

@MFlisar
Copy link
Contributor Author

MFlisar commented Mar 26, 2017

I'll add this tomorrow to my pull request...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants