Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepack/clean script fails on Windows #4

Open
Venryx opened this issue Nov 17, 2019 · 1 comment
Open

Prepack/clean script fails on Windows #4

Venryx opened this issue Nov 17, 2019 · 1 comment

Comments

@Venryx
Copy link
Contributor

Venryx commented Nov 17, 2019

The prepack script fails on Windows, due to multiple issues:

  1. Use of the rm command.

Solution: add shx as a dev-dependency, and have the script call shx rm instead: https://github.com/shelljs/shx

  1. Use of ESM=1 to set an environment variable.

Solution: use cross-env: https://github.com/kentcdodds/cross-env

@Venryx
Copy link
Contributor Author

Venryx commented Nov 17, 2019

Hmm, an issue is that dev-dependencies are not installed when running the prepack lifecycle script -- at least when installing using the npm install GithubUser/mst-decorators-type command.

Raised issue here asking for advice: shelljs/shx#168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant