Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OoT] Importing a DL with the custom path option doesn't work #384

Closed
Yanis42 opened this issue Jul 19, 2024 · 2 comments · Fixed by #410
Closed

[OoT] Importing a DL with the custom path option doesn't work #384

Yanis42 opened this issue Jul 19, 2024 · 2 comments · Fixed by #410
Labels
bug Something isn't working oot Has to do with the Ocarina of Time 64 side
Milestone

Comments

@Yanis42
Copy link
Contributor

Yanis42 commented Jul 19, 2024

I remember we talked about this a while ago on discord and it was brought to my attention again recently. The issue occurs when you try to import something with the DL Exporter with the "Use Custom Path" checkbox enabled (and the corresponding value set)

The error is the following: FileNotFoundError: [Errno 2] No such file or directory: '\\\\wsl.localhost\\Ubuntu-22.04\\home\\github\\oot\\assets\\objects\\gameplay_keep\\gameplay_keep.c\\gameplay_keepVtx_00D418.vtx.inc' (with gBoulderFragmentsDL), basically it keeps the C file part, I remember looking into this but I couldn't find the reason and I just gave up eventually

@Yanis42 Yanis42 added bug Something isn't working oot Has to do with the Ocarina of Time 64 side labels Jul 19, 2024
@Yanis42 Yanis42 added this to the v2.2.2 milestone Jul 19, 2024
@Dragorn421
Copy link
Contributor

In a custom export, there is no consideration of being in a decomp repo, you just have a file to read from. When a file does
#include "assets/scenes/overworld/spot01/spot01_room_0Vtx_001720.vtx.inc"
, what is fast64 supposed to do?
It doesn't have a decomp repo to look this up in

Currently for some reason fast64 uses the input .c path as that "decomp repo path" which is wrong and leads to the error you have. But I don't trust changing that logic, it may be relied upon elsewhere

@Dragorn421
Copy link
Contributor

based on this

# handle custom imports, where relative paths don't make sense
if not os.path.exists(vtxPath):
vtxPath = os.path.join(self.basePath, os.path.basename(path))

it seems like basePath being set as the input .c path is a mistake, the intent was setting the input .c 's folder parent path instead
I'll fix it that way.

Note this doesn't make dlists from maps very importable, for example it misses any texture that may be from the scene file (dlists are typically in room files). For example kakariko imports as fully black

Dragorn421 added a commit to Dragorn421/fast64 that referenced this issue Aug 8, 2024
Yanis42 pushed a commit that referenced this issue Aug 9, 2024
Fix #384 - Custom path DL imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working oot Has to do with the Ocarina of Time 64 side
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants