-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connected promoted inputs are considered as global inputs #334
Comments
Ok, this is a corner case that |
This issue will not impact the computation and thus the problem results. However, I find it confusing to have an output in the generated input file. The only place where this occurs in FAST-OAD is here when the |
Actually, you should find that this variable is no more in input file with current And since FAST-OAD always promotes all variables of its modules, the only place where a user can choose to connect a non promoted and a promoted variable, is inside his own components. And in that case, I am not really sure that it could have the effect you describe on the whole problem. My point is that I am not against doing that, but I just want to be sure it is worth it. |
There is an problem when determining wether if a variable is a global input of the problem when using the connect() mechanism with the promotion mechanism. In the example below,
y1
is an output ofdis1
and an input offunctions
which are both connected. Hence,y1.is_input
should beFalse
.The text was updated successfully, but these errors were encountered: