We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in nlp.py, get_rnn_classifer() is being called with an extra parameter, max_sl
In lm_rnn.py: def get_rnn_classifer(bptt, max_seq, n_class, n_tok, emb_sz, n_hid, n_layers, pad_token, layers, drops, bidir=False,
In nlp.py: m = get_rnn_classifer(max_sl, bptt, self.bs, self.c, self.nt,
The text was updated successfully, but these errors were encountered:
Should be fixed now. Please re-open if you still see a problem
Sorry, something went wrong.
@jph00, @gsgbills
I don't think it is fixed. Let's review In nlp.py max_sl still exists: m = get_rnn_classifer(max_sl, bptt, self.bs, se
In lesson4-imdb.ipynb we are passing a value of 1500 in the 6th cell in section Sentiment which seems to be for max_sl. What is max_sl??
it seems bptt is sequence length (as in torch) max_sl would then mean maximum sequence length (i think) why not set max_sl=bptt?
No branches or pull requests
in nlp.py, get_rnn_classifer() is being called with an extra parameter, max_sl
In lm_rnn.py:
def get_rnn_classifer(bptt, max_seq, n_class, n_tok, emb_sz, n_hid, n_layers, pad_token, layers, drops, bidir=False,
In nlp.py:
m = get_rnn_classifer(max_sl, bptt, self.bs, self.c, self.nt,
The text was updated successfully, but these errors were encountered: