Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear variables #162

Closed
imbolc opened this issue Feb 17, 2018 · 2 comments
Closed

Unclear variables #162

imbolc opened this issue Feb 17, 2018 · 2 comments

Comments

@imbolc
Copy link

imbolc commented Feb 17, 2018

Hi guys, thanks a lot for your job, it's the best ml course I've ever seen.

I just have a issue about variable names in notebooks and especially in fastai library. It's ok to read a notebook right after watching its lesson, but if I want to recall something after a few days, I can't do this just looking at code, e.g. lrf=learn.lr_find(), I need at least read markdown, think model.find_learn_rate() would be much understandable even without any comments.

Btw this does not prevent you to use shortcuts, you can add them as aliases, e.g. lr_find() would be an alias for find_learn_rate().

So what do you think? I will look at the code during the course anyway, so I would provide a few pull requests with improved var names if you agree.

@bhollan
Copy link

bhollan commented Feb 17, 2018

We actually had a discussion about this that was recently closed:
#86

A fellow student created kind of a glossary of sorts.

I hope this helps.

@imbolc
Copy link
Author

imbolc commented Feb 17, 2018

Thanks, @bhollan, going there :)

@imbolc imbolc closed this as completed Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants