Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cont_cat_split for multi-label classification #2759

Merged
merged 6 commits into from
Sep 9, 2020

Conversation

albertvillanova
Copy link
Contributor

Fix cont_cat_split to allow passing a list as dep_var.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

Copy link
Member

@jph00 jph00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests/docs that show things working for the single label and multi-label versions?

@jph00
Copy link
Member

jph00 commented Sep 9, 2020

Sorry about the CI issues - looking now.

@jph00 jph00 merged commit 2b2b970 into fastai:master Sep 9, 2020
@jph00
Copy link
Member

jph00 commented Sep 9, 2020

Thank you!

@jph00 jph00 added the bug label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants