Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastbook error: "index 3 is out of bounds for dimension 0 with size 3" #2792

Merged
merged 5 commits into from
Sep 14, 2020

Conversation

Tagar
Copy link
Contributor

@Tagar Tagar commented Sep 14, 2020

potential fix for fastai/fastbook#263

@Tagar Tagar requested a review from jph00 as a code owner September 14, 2020 04:49
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@Tagar
Copy link
Contributor Author

Tagar commented Sep 14, 2020

Looks like all tests passed except this one -

Screen Shot 2020-09-13 at 10 58 11 PM

The reason is that I didn't regenerate the callback/schedule.py from notebook, and not sure why that new line is now missing.

@Tagar
Copy link
Contributor Author

Tagar commented Sep 14, 2020

I tested locally with fastai installed from this branch (fastai/fastbook#263)
pip install git+git://github.com/Tagar/fastai.git

and it solves the issue

@Tagar
Copy link
Contributor Author

Tagar commented Sep 14, 2020

All tests pass now too.

@jph00
Copy link
Member

jph00 commented Sep 14, 2020

Many thanks!

@jph00 jph00 merged commit 2958b81 into fastai:master Sep 14, 2020
@jph00 jph00 added the bug label Sep 14, 2020
@jph00 jph00 changed the title fix fastai/fastbook/issues/263 fastbook error: "index 3 is out of bounds for dimension 0 with size 3" Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants