Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

xresnet meta.cut should be -4 #19

Closed
bearpelican opened this issue Dec 11, 2019 · 1 comment
Closed

xresnet meta.cut should be -4 #19

bearpelican opened this issue Dec 11, 2019 · 1 comment

Comments

@bearpelican
Copy link
Contributor

bearpelican commented Dec 11, 2019

Looks like there's 4 layers in the head:
https://github.com/fastai/fastai2/blob/master/fastai2/vision/models/xresnet.py#L41

However, cut says -4
https://github.com/fastai/fastai2/blob/master/fastai2/vision/learner.py#L86

Test case:
test_eq(bool(_is_pool_type(models.xresnet.xresnet34()[_xresnet_meta['cut']])), True)

@sgugger
Copy link
Contributor

sgugger commented Dec 11, 2019

It depends of the value of your dropout, but I made it always 4. Thanks for flagging!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants