Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

02_production: Updates needed for new Bing Image Search API #333

Merged
merged 1 commit into from Nov 29, 2020

Conversation

joshkraft
Copy link
Contributor

Hi FastAI team,

There have been some recent updates to the Bing Image Search API, and 02_production.ipynb no longer works out of the box as a result. There has been some discussion about this over on the forums over the past few months:

https://forums.fast.ai/t/02-production-permissiondenied-error/65823/19

I don't see any pull requests created yet, so I went ahead and proposed the following changes:

  1. Update search_images_bing() function in utils.py
  2. Update the call to download_images in 02_production.ipynb

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@miramar-labs
Copy link

I verified the fix is good with the new Bing API ....

@chuckinator0
Copy link

I had to make this change in the _init_.py file in the site-packages folder because changes weren't picked up in utils.py

@ESKYoung
Copy link

This has been really helpful thanks @joshkraft! Couple of things I noticed:

  • There's a cell with the line ims = results.attrgot('content_url'), which needs to be changed to ims = results.attrgot('contentUrl')
  • The changes need to be copied over to the equivalent notebook in the clean folder

@jph00
Copy link
Member

jph00 commented Nov 29, 2020

Many thanks! I'll fix that in the fastbook pypi package too.

@jph00 jph00 merged commit d9a9be4 into fastai:master Nov 29, 2020
Caruso33 pushed a commit to Caruso33/fastbook that referenced this pull request Dec 25, 2020
georghoeller pushed a commit to georghoeller/fastbook that referenced this pull request Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants