New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search_images_ddg(key,max_n=200) #362
Comments
Hi prairie-guy, What exactly wasn't working with search_images_ddg? I was having an issue where
on the line 57 of fastbook/ I got around the issue by pasting the fixed function currently in utils.py into a code cell. |
As you point out, the fastbook github code (which I originally submitted ) works. The problem is with the version of the function called by: |
I wrote the pull request for |
I'd also note that the course uses |
As author of the function
search_images_ddg (key,max_n=200)
, I have gotten several complaints of it not working. The function in the github repositoryutils.py/search_images_ddg
works as expected.The problem is with the pip package version,
fastbook-0.0.16.tar.gz
https://pypi.org/project/fastbook/#modal-close, where the file:__init__.py
overwrites and breaks the working version ofsearch_images_ddg
Could the author of the pip package update it with working code from github, or else fix the the pip package version of the function and then update the github repository so there is only one version of the function?
Thanks
The text was updated successfully, but these errors were encountered: