Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct footnote example in _test.ipynb? #12

Open
lewtun opened this issue Dec 25, 2020 · 2 comments · May be fixed by #14
Open

Correct footnote example in _test.ipynb? #12

lewtun opened this issue Dec 25, 2020 · 2 comments · May be fixed by #14

Comments

@lewtun
Copy link
Contributor

lewtun commented Dec 25, 2020

Hi @jph00,

In the test notebook, the footnote example is shown as

A footnote[this is a footnote]

however my understanding from the AsciiDoc docs is that a colon is required to render the footnote, i.e.

A footnote:[this is a footnote]

If you agree, I'd be happy to fix the test notebook!
@jph00
Copy link
Member

jph00 commented Jan 10, 2021 via email

@lewtun lewtun linked a pull request Jan 19, 2021 that will close this issue
Open
@lewtun
Copy link
Contributor Author

lewtun commented Jan 19, 2021

Hi Jeremy, yes I tried both and have opened a PR with the fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix footnotes lewtun/fastdoc
2 participants
@jph00 @lewtun