Skip to content
This repository has been archived by the owner on Nov 13, 2022. It is now read-only.

Delay first build upon checking out repo template #39

Closed
FReeshabh opened this issue Feb 14, 2020 · 13 comments · Fixed by #69
Closed

Delay first build upon checking out repo template #39

FReeshabh opened this issue Feb 14, 2020 · 13 comments · Fixed by #69
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation in-progress

Comments

@FReeshabh
Copy link

FReeshabh commented Feb 14, 2020

The tag twitter on line 73 in _posts/2020-01-14-welcome.md is not a recognized Liquid tag.

Getting this error, getting other errors after removing line 73, mostly twitter not working

@hamelsmu hamelsmu added the bug Something isn't working label Feb 14, 2020
@hamelsmu hamelsmu self-assigned this Feb 14, 2020
@hamelsmu
Copy link
Member

@FReeshabh are you using the most up to date version of this repo? I no longer have a post called 2020-01-14-welcome.md. This repo is being developed rapidly so it could be this was previously addressed or fixed.

The current version in master is rendering tweetcards correctly. I'll close this for now, please reopen if you are able to reproduce this from the current version .

🙇 thank you!

@hamelsmu
Copy link
Member

P.S. Cool Blog, https://freeshabh.github.io/ BTW! If you do manage to use this template successfully especially with Jupyter please let me know!

@hamelsmu
Copy link
Member

@FReeshabh I just realized you are using fast_template for your blog. Please keep in mind that fastpages is a separate project and features here may not work with fast_template. I suggest you fork this repo for your blog instead if you want these additional features.

@FReeshabh
Copy link
Author

FReeshabh commented Feb 14, 2020

@hamelsmu Oh alright, I am currently using fast_template, as it was easier to setup, I'm currently getting a few errors in fastpages template. Such as this

Run import os
Traceback (most recent call last):
  File "/home/runner/work/_temp/ca3ac390-3895-4490-9d74-1dd4e1f891de.py", line 3, in <module>
    assert status == 'built', 'There was an error building the page on GitHub pages.\n\nStatus: {}\n\nError messsage: {}'.format(status, errormsg)
AssertionError: There was an error building the page on GitHub pages.

Status: errored

Error messsage: The tag `twitter` on line 73 in `_posts/2020-01-14-test-markdown-post.md` is not a recognized Liquid tag. For more information, see https://help.github.com/en/github/working-with-github-pages/troubleshooting-jekyll-build-errors-for-github-pages-sites#unknown-tag-error.
##[error]Process completed with exit code 1.

Another issue that I think is happening, is Github Pages not allowing me to switch gh-pages. I am going to see if just converting Jupyter Notebooks to HTML files and uploading them will work better

@drscotthawley
Copy link
Contributor

I realize this is closed, but I get essentially the same error with a fresh checkout of the latest version of the fastpages repo, so thought I'd post here:

"Your site is having problems building: The tag twitter on line 73 in _posts/2020-01-14-test-markdown-post.md is not a recognized Liquid tag. For more information, see https://help.github.com/en/github/working-with-github-pages/troubleshooting-jekyll-build-errors-for-github-pages-sites#unknown-tag-error."

I can open a new Issue if you prefer.

My cloned fastpages repo is https://github.com/drscotthawley/devblog2

@hamelsmu
Copy link
Member

Hi @drscotthawley this is your error: https://github.com/drscotthawley/devblog2/runs/449901792?check_suite_focus=true#step:5:901

Something about an embedded picture that is causing problems in your notebook conversion. I’ll take a look at this sometime next week.

@hamelsmu hamelsmu reopened this Feb 17, 2020
@hamelsmu hamelsmu changed the title Site broken Notebook Linked Image Causes Conversion & Build Failure Feb 17, 2020
@drscotthawley
Copy link
Contributor

drscotthawley commented Feb 17, 2020

Oh wow, we were working at the exact same time tonight! The error you mentioned just now is after adding some new posts -- I just opened an issue on that seconds ago: #58

But when I wrote on this problem above in this Issue, it was a brand-new check-out of the repository, with no other posts but the original post included in the template. (which was giving the twitter error.)

@hamelsmu
Copy link
Member

Oh in that case, I believe your first error is user error: https://github.com/drscotthawley/devblog2/runs/449804933?check_suite_focus=true#step:8:13

You forgot to set the deploy key? If so please close this issue

@hamelsmu
Copy link
Member

I know why this happens, it is because when you first check out the template, GitHub makes an initial commit to master, this triggers the entire workflow right away, before you have a chance to set anything up. You get an error initially, but then after you fix everything the error goes away.

I should re-arrange the order of the setup steps so this goes away. I’m working on a solution right now that will automate all the setup steps and this problem will then go away, hopefully.

We should leave this issue open

@hamelsmu hamelsmu changed the title Notebook Linked Image Causes Conversion & Build Failure Delay first build upon checking out repo template Feb 17, 2020
@hamelsmu hamelsmu added documentation Improvements or additions to documentation in-progress labels Feb 17, 2020
@drscotthawley
Copy link
Contributor

Ah, ok! Thanks. I have re-added your original markdown post, and confirmed that it builds correctly with the original twitter tag as you have it.

(I temporarily removed the notebook file that was causing other problems.)

@hamelsmu
Copy link
Member

I changed the ordering of the setup instructions if anyone wants to go ahead and give it a shot. The new ordering of steps should avoid confusing error messages.

@hamelsmu hamelsmu mentioned this issue Feb 17, 2020
@jxyztplk
Copy link

I'm still getting this error:
1_see-page-build-payload.txt

my cloned repo: https://github.com/DataLovecraft/DataLovecraft.github.io

For step 1, in deploying your ssh, 'Make sure you select Allow write access when adding this key to your GitHub account.'

Do I need a specific name? or can I name it anything, and this is where the public key goes?

@hamelsmu
Copy link
Member

hamelsmu commented Feb 18, 2020

#69 will close this issue, we are rebuilding the setup process to make it easier to follow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documentation Improvements or additions to documentation in-progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants