Skip to content
This repository has been archived by the owner on Nov 13, 2022. It is now read-only.

Support for embedded image objects #71

Closed
hamelsmu opened this issue Feb 18, 2020 · 9 comments
Closed

Support for embedded image objects #71

hamelsmu opened this issue Feb 18, 2020 · 9 comments
Labels
enhancement New feature or request help wanted Extra attention is needed nbdev

Comments

@hamelsmu
Copy link
Member

See #66

Copy and pasting comment by @drscotthawley:


I found a tricky interaction between nbdev & the fastpages build.

nbdev is replacing "<img src=" HTML code with Liquid "{% img src" tags.

This might not be a problem ordinarily, but when running with Liquid in fastpages, it can't handle long "src" strings.

So here's a question for both @sgugger and @hamelsmu:
Would it be better to NOT have nbdev translate the HTML "img src" tags into Liquid, or would it be better to provide fastpage's Liquid run with...whatever it needs to handle long src strings?

The original HTML code in question:

<img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAM0AAACXCAYAAAC2qd/4AAAF4nRFWHRteGZpbGUAJTNDbXhmaWxlJTIwaG9zdCUzRCUyMnd3dy5kcmF3LmlvJTIyJTIwbW9kaWZpZWQlM0QlMjIyMDE5LTEyLTIwVDIxJTNBMjQlM0ExMS45MjRaJTIyJTIwYWdlbnQlM0QlMjJNb3ppbGxhJTJGNS4wJTIwKE1hY2ludG9zaCUzQiUyMEludGVsJTIwTWFjJTIwT1MlMjBYJTIwMTBfMTVfMCklMjBBcHBsZVdlYktpdCUyRjUzNy4zNiUyMChLSFRNTCUyQyUyMGxpa2UlMjBHZWNrbyklMjBDaHJvbWUlMkY3OS4wLjM5NDUuODglMjBTYWZhcmklMkY1MzcuMzYlMjIlMjBldGFnJTNEJTIyWnlaOEUxZjNhMW9ocEFIRDJjWEslMjIlMjB2ZXJzaW9uJTNEJTIyMTIuNC4zJTIyJTIwdHlwZSUzRCUyMmdvb2dsZSUyMiUyMHBhZ2VzJTNEJTIyMSUyMiUzRSUzQ2RpYWdyYW0lMjBpZCUzRCUyMm9vV2FBMW83X2ljR18zc1RKd2ZsJTIyJTIwbmFtZSUzRCUyMlBhZ2UtMSUyMiUzRTdWZGRiNXN3RlAwMVNOdERJckFEcEklMkY1S052REpsWHFReDhuRnh5d1lqQXpUa2o2NjNlTlRjSkgwcTVWTjJsVG8wakI1MTdmYTg3eHNSd0hyJTJGTERGMG5LN0x0SUtIZVFteHdjdkhZUThtYnpBSDQwY3JTSTN5S3BaSW5GenNBOWU2SVdkQzI2WXdtdGVvbEtDSzVZMlFkalVSUTBWajJNU0NucWZ0cEc4SDdYa3FSMEJOekhoSSUyRlJCNWFvektCejN6M2pYeWxMczdhejU5cElUdHBrVzZMS1NDSnFBelU1JTJCTmJCS3ltRU1rJTJGNVlVVzVacSUyRmx4UlNLcmtSUEM1TzBVTDh6SWJrcnFaOCUyQnBkOFc5ZE1tSWclMkZiYmVSTzVxYktudkNkZldFSEJSenFMUk8yMTR0V1I4dEU4SE9uVjdwVTlLQW1oTE8wY1BBQ01qamRhTGpodGxDVHFsRlFCN3l3UERTQmRpWThwZmEzNlpCNUZ4dTh0a3hWa3VKNm9RM0pHVCUyQmFVaEFpZVFrUm14Q0xuV1JVUXFTZzlURG9vRld6cld5S0h1U2lFTkF0cHMlMkIlMkZyd25VZGxmbzBBdzJSUk41SlBFMmxXSlhKSk5ZY0NGTldLYVBuNUR2bXliZGg4OVhYbnltdiUyRjVxVDJNblhPNmRjUDJEV2RCeUFydkEwTktuQ21CTiUyQmdoc3RHNVIxQ01UYWIyMVdDcm5BSGlhY0NYRmxxN00lMkJ0ZUZLRFFmRzhiNUFMS2JaQjNEQmdVSzhYSlBwV0pncllVTjVDeEpkSnRsblRGRjd3Mno2eHBPRXNBYWxxamV1MjR6VWtReG9XZE5zR3ZGdGFlRkY1N1dyVHZRdzFXRGVDZmJ3WUZGUlU2VlBFS0tuV0Q5NDlxakN0dGhmYlo5TUp1NnlLQlp4JTJGVHRSR0xQbXZSVSUyQm14SGVMQ09mSVU3Z3c5MyUyRnF2dURKZGcwTWNOWkM3QW54OW1mVyUyQnp6b0pwaU56T0olMkJpWk4lMkZDbUliN3BmUHlSbVQyRXBpMzhWOXdjWG5EelFEOWFKQXQ5YWRGQ2NGSlZMSDVPVFFmaFdSaEZ3U1dLOVhnZ3NabmMzbUx3U1FlYWpLNUFMNnJRNGJHOUNuVTViREZKT2V5RWZiJTJGOEpXSnRoenZCb1BGSjVNQ2QzdUNlcnA0M1VLZUNJeUNtZGw3MzlqTW81Y0haUGFqbEQwb3BJbE9xUnFVYXJVJTJCdiUyRm5iNWIlMkY2QSUyRk83YTg2UG9mNVVmbzZGa0FYNmIlMkJ2T1IlMkJCaSUyRmslMkZnd1BOJTJGaFRmcjVyeEMlMkIlMkZRVSUzRCUzQyUyRmRpYWdyYW0lM0UlM0MlMkZteGZpbGUlM0XlLOgaAAAOIklEQVR4Xu2de4zcVRXHv2d2K7Z0H8BuRUCJ4htMKjYxKpiKbHchFB8R/jDSnRaFaFRa4wMTdX+jEQU1QH03WmapMSYYNQFlt60KkWqiqRG1RE1ENEagW6HdLa+2O8ecmd9uZ2Z3Hndmfs/53n826dzfvXc+53z7u3PvOfcKWEiABJwIiFNtViYBEgBFQycgAUcCFI0jMFYnAYqGPkACjgQoGkdgrE4CFA19gAQcCVA0jsBYnQQoGvoACTgSoGgcgbE6CVA09AEScCRA0TgCY3USoGjoAyTgSICicQTG6iRA0dAHSMCRAEXjCIzVSYCioQ+QgCMBisYRGKuTAEVDHyABRwIUjSMwVicBioY+QAKOBCgaR2CsTgIUDX2ABBwJUDSOwFidBCga+gAJOBKgaByBsToJUDT0ARJwJEDROAJjdRKgaOgDJOBIgKJxBMbqJEDR0AdIwJEAReMIjNVJgKKhD5CAIwGKxhEYq5MARUMfIAFHAhSNIzBWJwGKhj5AAo4EKBpHYKxOAhQNfYAEHAlQNI7AWJ0EKBr6AAk4EqBoHIGxOglQNPQBEnAkQNE4AmN1EqBo6AMk4EiAoikBWwdgHsA/AMw6MmT1LiNA0ZQM/mIAewC8AsAbAPwuTD84dVjXimJgoc+MYG1BMdjbi8nDj8kjYY6FfTUmQNEAlwK4HcCzPi5762hjdPVr9A1rVhXnQjAowNqq2uubaP/+uRlppl4TTbFKJwl0s2heBuArAN4IYCuAnwB4D4CdnQA8OKiDJ1bAE+CGFto70tODtXzLtEAuhEe6VTTnAHgIwFd94TwVFOvVQ7pegDwE5zbbhyi2zR6S25qtz3rhEuhW0RjlMwD8bxncKwFcAeDusilbW1ZxfOtwWtYW7eAf7mbR1KI7BuBeAF8G8AkArwXweQDvaNccfcN6E4CPA+it0RanZe1CDuF5iqYE+TQA7wXwNQDGxFbQbgEwAqAA4OUA/gngmVZs0jesF4liQqW46FCziCA3e1C8VvrgM+ERoGhKgtkLwH7nnFm2cmZvlhMAfumL6Q8AvuFimlVDelZPBhNQXFfxnOAYFM+rauvBuRmpXmVz6Y51QyJA0QAXAhgFYFOnCwAc8NnbD3cTzvf8z68FcHmzdukb1hsBTAB4ftUzNwN4E4CLy/+9ALzuqRn5Y7Pts150BCiak9OzJwB8qOxtYm+eawB8EShuPB4GcCqAp+uZa/WwXi1SfLu8pqreXdqD3NHH5ED/GvVUi4IqFk7LohNAKz1TNCepWRTAf8t+8Ns+zjv9BQGr9StfUDZNe7ga9sCQriuYWEorb4tFgf2iyM0dEluNK5Yq0XBa1ornRvgMRXMSvq2QfRrAKQCO+atc9wH4vV/lw/5q2vnl8Wn9/Xp64RRMCPCRKjs+KUBudkYs2qCilIuG07IIvb/Frimak+Dsd8Y+AN8GYG8TWxQwIS2UVQBMMAsiQv+w3qCl3y22mFD+dtnecwzekSPy5HJ2WRANp2Utem3Ej1E0Jw1gLL4D4O0Avgngc7Vi0PqGdKNKMUTGFhHKyz0ZhXfkkOyvZ9dilIDgNq6WRez9LXZP0TiAW32mni/zsH2Ud1c8JnhIFd7RGbmrmeZMNCo4zNWyZmjFrw5F04xNztGVfc/CgxQjBMqLRUZ7czNiy8gsXUKAomlg6NVDen1xCRl4YdXbZcd8Ad7Th+TRLvEVfk2fAEVTwxUG1uhIobSX8ubyKqLYqxl4cwfFFg1YYkBgRLNreyGLSXwF6FoFBjPA5JTkO57ER9FUGX1gjZ5XKGACUtzYLC8Pi8CbPSi7YuAnqR/CmGazBeBcAQbRQhKfAvfvlnwgSXwUzaL7qfSvwUT5Tv3CR1waDl+j6zU7eAqKiy4tJfFZtmwQbxkjQdGUdug32eoXgJdUuIdiV6YH3pHHZUkEQPhu1J09jml2vVoSH5pP4gOwbVrygSXxdbVo/JB9TwVvq3LJfYUMvKceF4t+ZomYgMtbJ8hp2eLMI2IekXS/8gw9u7enGFT5/qoBPFrcbzkkOyIZGDutS2CDjt8kxSQ+qZnEF+S0rGtFUy9kf+5UeHhEFk6loQvHhMCYbrlIoROA1k/iA3JTkg88ia9rpmd1Q/bn4R19QuygDZYYERjRLWf1QCcUWpnEVwqoXZLENy35UJL4Ui+aBiH73twhuSdGfsKh+AQ2aPZGcUzi2yP5UJL4UiuaBiH73uyMbKeHxo/AqI5fDYhtKlck8Slwl0Bz0zJ5YEyznh9dXvwCloIRxrQs1b9p+od0q5ZCX2xjbLEocHvPMeRqhezHz4UCHdFL/fQHO7/68UB7aqLxEb1mXQaZCUAqkvgA7Fcgt1vyi0l8VaJ5MKxpWSpF0zekV5pYlgnZvzujyDUK2W/Ctmmqsto//+BqAB/zD04M/fuN6rWnKwoTAl2SxAcgNy35JUl85aKxJL6wpmWpE83AkF5YEFTmsSgOqCDXbMh+6B4TXYd2JJWdLmpHVdnZB7ZP9Z+whzOqWdvtXyaJT7avwHPez+QHyybxLYgm7GlZ6kRjX2j1sN4qpXOZ7XyyHEP2l8jAgho/BeCTvrPaWdbjAL4VpmA2aHaj/yP/9ZX96j0KeLtlsm4Snx8lcFvY07JUiua003TgxArcwpD9ZSVgiz5/AWArTCacf4cpFOtrVMfPN1EIpDKJD3hIAG9K8k0l8Zlo5oHDYU/LUimasJ0ggf25nF/9gk4tEFylV62cxSoPkGWT+KYln6gkvtQuOSfQoaMccvX51eYXRwC8yP/b8tjGdPP1pd38yiQ+geyYh+T2yE47NitRhaJJlLk6Oth651c/5x/Sbme//bWVXjdodiQDTGhVEh8gewUnclOy64FW2o3DMxRNHKzQ2TH0+PeH1mu10fnVPwfwBT9r9S0uw7tMx88rlDYnK5L4BHhYS5uTd7q0F8e6FE0crdLemOxH/qsBfBDA0RpNNTq/2vZG7Jw3u+zKBGbL0vWLQsaQtTfL4nG7ZT+cQ92xbzTUdj+naNolGL/n7X94+9/87/5RU3+uMUQTQ73zq+0xi8v7LoCf1vuaozq+SSAmGIsyKC+7TiDj/UJ2piqJj6KJn9O3O6KLAPy6rJHNKGU+LlcanV/9AQC2l/JD/zqSijZKIfsFC8WvSOITYJ8i403LzlQm8VE07bpo/J4/e5ndfRON3YhQfbdoo/Or7ar4fwF4FYC/LXxVC9nPlMSyNIkPapuTqU7io2ji5/TtjigDwA5u/zGAW8sas+nau8ru37GPGp1fbXX6yw98rxey/xzg3Sf51CfxUTTtumg8n/+tLwi77t2uel9TY7rW9PnV9UL2eyDevXJH1yTxUTTxdPp2R/UjlK7+OAjgswA+U9WghavYZVU29bLFgJrFJWS/3UEn5XmKJimWchvnl/yg1Sv9adrXffF8tKyZP/l7KfZ3SWklZN9tiMmtTdEk13b1Rv4+AJYns6VqUWDKn7ZZJPhkrU1QC9kvBVZWJ/Hp9hU4XjNkP50ol34riiadlr7Ev1TXkssWih3RajFm9hZadrPyMs1uLJROtay6d6e5kP10oqRousWutsloeytv9Ve/6t5sYCH7FpqvbYbsdwtcvmnSaelX+oGWtsxsm5u/We5rXqXbVs7iidSE7IdlSoomLNLh9rMNwHH/OkT7u6TUC9lXrPCmZQfv3alhM4omXGeOvLfaIfu6NwN498ok791pYCWKJnI3DmcA9UP24U1LnvfuNGkKiqZJUImt1kUh+2HZiKIJi3QE/Yzqlk3AvP3Qr7x3B0hlyH5YiCmasEiH2E+tkH0F9kmKQ/bDQkzRhEU6hH5qh+zro/55YqkO2Q8BcbELiiYs0gH3w5D9gAGXNU/RhMc6kJ4Ysh8I1rqNUjThM+9IjyO6ZV0G8zVO2Rdvt9zBe3c6QnppIxRNQGCDarZeyL5AvCm5g/fuBAXfb5eiCRhwJ5uvFbIP4PZeHMvVOmW/k2NgW1wISIQPMGQ/XmbimyZe9qgYzQa95gK7HYwh+/EyEkUTL3sUR7NRr1t1DMftCvBUnLIfQ8RtDYmiaQtf5x+uH7J/3JuW7zNkv/PYnVqkaJxwBVe5Xsi+pSDvYch+cPAdW6ZoHIF1ujpD9jtNNPj2KJrgGS/fQ52Q/VKcWD4X1dDYb30CFE0EHrJBN48LCrabXxWyL3eegOTSdsp+BIgD7ZKiCRRvZeOjmr3Yv1W54pR9QB4A5nPTcmcqT9kPEXEoXVE0IWC+RDedvQIZu+yo6pR9huyHgL/jXVA0HUda2SBD9gMGHEHzFE1A0BmyHxDYGDRL0XTYCJfrlnXzxSvA9YqqpvcrGLLfYdyRNEfRdAi7hezbiphC7YqL8vKkQL0pmWTIfodYR90MRdMBC4xqdqvdalx9yj5D9jsAN4ZNUDRtGGVMx69UiK2KVZyyL8DdBWhut0zub6N5PhpTAhRNi4YZ1c0XAlotigMC5KYkbzeNsaSUAEXThmFHNWsXwW4V4BkFctOSv7mN5vhoQghQNG0Y6lK9bqAXx29RMGS/DYyJe5SiSZzJOOCoCVA0UVuA/SeOAEWTOJNxwFEToGiitgD7TxwBiiZxJuOAoyZA0URtAfafOAIUTeJMxgFHTYCiidoC7D9xBCiaxJmMA46aAEUTtQXYf+IIUDSJMxkHHDUBiiZqC7D/xBGgaBJnMg44agIUTdQWYP+JI0DRJM5kHHDUBCiaqC3A/hNHgKJJnMk44KgJUDRRW4D9J44ARZM4k3HAUROgaKK2APtPHAGKJnEm44CjJkDRRG0B9p84AhRN4kzGAUdNgKKJ2gLsP3EEKJrEmYwDjpoARRO1Bdh/4gj8H0PO0sVrUy0IAAAAAElFTkSuQmCC" style="cursor:pointer;max-width:100%;" onclick="(function(img){if(img.wnd!=null&&!img.wnd.closed){img.wnd.focus();}else{var r=function(evt){if(evt.data=='ready'&&evt.source==img.wnd){img.wnd.postMessage(decodeURIComponent(img.getAttribute('src')),'*');window.removeEventListener('message',r);}};window.addEventListener('message',r);img.wnd=window.open('https://www.draw.io/?client=1&lightbox=1&edit=_blank');}})(this);"/>

This is getting converted by nbdev to

{% include image.html style="cursor:pointer;max-width:100%;" onclick="(function(img){if(img.wnd!=null&amp;&amp;!img.wnd.closed){img.wnd.focus();}else{var r=function(evt){if(evt.data=='ready'&amp;&amp;evt.source==img.wnd){img.wnd.postMessage(decodeURIComponent(img.getAttribute('src')),'*');window.removeEventListener('message',r);}};window.addEventListener('message',r);img.wnd=window.open('<a href="https://www.draw.io/?client=1&amp;lightbox=1&amp;edit=_blank&#39;);}})(this">https://www.draw.io/?client=1&amp;lightbox=1&amp;edit=_blank&#39;);}})(this</a>);" file="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAM0AAACXCAYAAAC2qd/4AAAF4nRFWHRteGZpbGUAJTNDbXhmaWxlJTIwaG9zdCUzRCUyMnd3dy5kcmF3LmlvJTIyJTIwbW9kaWZpZWQlM0QlMjIyMDE5LTEyLTIwVDIxJTNBMjQlM0ExMS45MjRaJTIyJTIwYWdlbnQlM0QlMjJNb3ppbGxhJTJGNS4wJTIwKE1hY2ludG9zaCUzQiUyMEludGVsJTIwTWFjJTIwT1MlMjBYJTIwMTBfMTVfMCklMjBBcHBsZVdlYktpdCUyRjUzNy4zNiUyMChLSFRNTCUyQyUyMGxpa2UlMjBHZWNrbyklMjBDaHJvbWUlMkY3OS4wLjM5NDUuODglMjBTYWZhcmklMkY1MzcuMzYlMjIlMjBldGFnJTNEJTIyWnlaOEUxZjNhMW9ocEFIRDJjWEslMjIlMjB2ZXJzaW9uJTNEJTIyMTIuNC4zJTIyJTIwdHlwZSUzRCUyMmdvb2dsZSUyMiUyMHBhZ2VzJTNEJTIyMSUyMiUzRSUzQ2RpYWdyYW0lMjBpZCUzRCUyMm9vV2FBMW83X2ljR18zc1RKd2ZsJTIyJTIwbmFtZSUzRCUyMlBhZ2UtMSUyMiUzRTdWZGRiNXN3RlAwMVNOdERJckFEcEklMkY1S052REpsWHFReDhuRnh5d1lqQXpUa2o2NjNlTlRjSkgwcTVWTjJsVG8wakI1MTdmYTg3eHNSd0hyJTJGTERGMG5LN0x0SUtIZVFteHdjdkhZUThtYnpBSDQwY3JTSTN5S3BaSW5GenNBOWU2SVdkQzI2WXdtdGVvbEtDSzVZMlFkalVSUTBWajJNU0NucWZ0cEc4SDdYa3FSMEJOekhoSSUyRlJCNWFvektCejN6M2pYeWxMczdhejU5cElUdHBrVzZMS1NDSnFBelU1JTJCTmJCS3ltRU1rJTJGNVlVVzVacSUyRmx4UlNLcmtSUEM1TzBVTDh6SWJrcnFaOCUyQnBkOFc5ZE1tSWclMkZiYmVSTzVxYktudkNkZldFSEJSenFMUk8yMTR0V1I4dEU4SE9uVjdwVTlLQW1oTE8wY1BBQ01qamRhTGpodGxDVHFsRlFCN3l3UERTQmRpWThwZmEzNlpCNUZ4dTh0a3hWa3VKNm9RM0pHVCUyQmFVaEFpZVFrUm14Q0xuV1JVUXFTZzlURG9vRld6cld5S0h1U2lFTkF0cHMlMkIlMkZyd25VZGxmbzBBdzJSUk41SlBFMmxXSlhKSk5ZY0NGTldLYVBuNUR2bXliZGg4OVhYbnltdiUyRjVxVDJNblhPNmRjUDJEV2RCeUFydkEwTktuQ21CTiUyQmdoc3RHNVIxQ01UYWIyMVdDcm5BSGlhY0NYRmxxN00lMkJ0ZUZLRFFmRzhiNUFMS2JaQjNEQmdVSzhYSlBwV0pncllVTjVDeEpkSnRsblRGRjd3Mno2eHBPRXNBYWxxamV1MjR6VWtReG9XZE5zR3ZGdGFlRkY1N1dyVHZRdzFXRGVDZmJ3WUZGUlU2VlBFS0tuV0Q5NDlxakN0dGhmYlo5TUp1NnlLQlp4JTJGVHRSR0xQbXZSVSUyQm14SGVMQ09mSVU3Z3c5MyUyRnF2dURKZGcwTWNOWkM3QW54OW1mVyUyQnp6b0pwaU56T0olMkJpWk4lMkZDbUliN3BmUHlSbVQyRXBpMzhWOXdjWG5EelFEOWFKQXQ5YWRGQ2NGSlZMSDVPVFFmaFdSaEZ3U1dLOVhnZ3NabmMzbUx3U1FlYWpLNUFMNnJRNGJHOUNuVTViREZKT2V5RWZiJTJGOEpXSnRoenZCb1BGSjVNQ2QzdUNlcnA0M1VLZUNJeUNtZGw3MzlqTW81Y0haUGFqbEQwb3BJbE9xUnFVYXJVJTJCdiUyRm5iNWIlMkY2QSUyRk83YTg2UG9mNVVmbzZGa0FYNmIlMkJ2T1IlMkJCaSUyRmslMkZnd1BOJTJGaFRmcjVyeEMlMkIlMkZRVSUzRCUzQyUyRmRpYWdyYW0lM0UlM0MlMkZteGZpbGUlM0XlLOgaAAAOIklEQVR4Xu2de4zcVRXHv2d2K7Z0H8BuRUCJ4htMKjYxKpiKbHchFB8R/jDSnRaFaFRa4wMTdX+jEQU1QH03WmapMSYYNQFlt60KkWqiqRG1RE1ENEagW6HdLa+2O8ecmd9uZ2Z3Hndmfs/53n826dzfvXc+53z7u3PvOfcKWEiABJwIiFNtViYBEgBFQycgAUcCFI0jMFYnAYqGPkACjgQoGkdgrE4CFA19gAQcCVA0jsBYnQQoGvoACTgSoGgcgbE6CVA09AEScCRA0TgCY3USoGjoAyTgSICicQTG6iRA0dAHSMCRAEXjCIzVSYCioQ+QgCMBisYRGKuTAEVDHyABRwIUjSMwVicBioY+QAKOBCgaR2CsTgIUDX2ABBwJUDSOwFidBCga+gAJOBKgaByBsToJUDT0ARJwJEDROAJjdRKgaOgDJOBIgKJxBMbqJEDR0AdIwJEAReMIjNVJgKKhD5CAIwGKxhEYq5MARUMfIAFHAhSNIzBWJwGKhj5AAo4EKBpHYKxOAhQNfYAEHAlQNI7AWJ0EKBr6AAk4EqBoHIGxOglQNPQBEnAkQNE4AmN1EqBo6AMk4EiAoikBWwdgHsA/AMw6MmT1LiNA0ZQM/mIAewC8AsAbAPwuTD84dVjXimJgoc+MYG1BMdjbi8nDj8kjYY6FfTUmQNEAlwK4HcCzPi5762hjdPVr9A1rVhXnQjAowNqq2uubaP/+uRlppl4TTbFKJwl0s2heBuArAN4IYCuAnwB4D4CdnQA8OKiDJ1bAE+CGFto70tODtXzLtEAuhEe6VTTnAHgIwFd94TwVFOvVQ7pegDwE5zbbhyi2zR6S25qtz3rhEuhW0RjlMwD8bxncKwFcAeDusilbW1ZxfOtwWtYW7eAf7mbR1KI7BuBeAF8G8AkArwXweQDvaNccfcN6E4CPA+it0RanZe1CDuF5iqYE+TQA7wXwNQDGxFbQbgEwAqAA4OUA/gngmVZs0jesF4liQqW46FCziCA3e1C8VvrgM+ERoGhKgtkLwH7nnFm2cmZvlhMAfumL6Q8AvuFimlVDelZPBhNQXFfxnOAYFM+rauvBuRmpXmVz6Y51QyJA0QAXAhgFYFOnCwAc8NnbD3cTzvf8z68FcHmzdukb1hsBTAB4ftUzNwN4E4CLy/+9ALzuqRn5Y7Pts150BCiak9OzJwB8qOxtYm+eawB8EShuPB4GcCqAp+uZa/WwXi1SfLu8pqreXdqD3NHH5ED/GvVUi4IqFk7LohNAKz1TNCepWRTAf8t+8Ns+zjv9BQGr9StfUDZNe7ga9sCQriuYWEorb4tFgf2iyM0dEluNK5Yq0XBa1ornRvgMRXMSvq2QfRrAKQCO+atc9wH4vV/lw/5q2vnl8Wn9/Xp64RRMCPCRKjs+KUBudkYs2qCilIuG07IIvb/Frimak+Dsd8Y+AN8GYG8TWxQwIS2UVQBMMAsiQv+w3qCl3y22mFD+dtnecwzekSPy5HJ2WRANp2Utem3Ej1E0Jw1gLL4D4O0Avgngc7Vi0PqGdKNKMUTGFhHKyz0ZhXfkkOyvZ9dilIDgNq6WRez9LXZP0TiAW32mni/zsH2Ud1c8JnhIFd7RGbmrmeZMNCo4zNWyZmjFrw5F04xNztGVfc/CgxQjBMqLRUZ7czNiy8gsXUKAomlg6NVDen1xCRl4YdXbZcd8Ad7Th+TRLvEVfk2fAEVTwxUG1uhIobSX8ubyKqLYqxl4cwfFFg1YYkBgRLNreyGLSXwF6FoFBjPA5JTkO57ER9FUGX1gjZ5XKGACUtzYLC8Pi8CbPSi7YuAnqR/CmGazBeBcAQbRQhKfAvfvlnwgSXwUzaL7qfSvwUT5Tv3CR1waDl+j6zU7eAqKiy4tJfFZtmwQbxkjQdGUdug32eoXgJdUuIdiV6YH3pHHZUkEQPhu1J09jml2vVoSH5pP4gOwbVrygSXxdbVo/JB9TwVvq3LJfYUMvKceF4t+ZomYgMtbJ8hp2eLMI2IekXS/8gw9u7enGFT5/qoBPFrcbzkkOyIZGDutS2CDjt8kxSQ+qZnEF+S0rGtFUy9kf+5UeHhEFk6loQvHhMCYbrlIoROA1k/iA3JTkg88ia9rpmd1Q/bn4R19QuygDZYYERjRLWf1QCcUWpnEVwqoXZLENy35UJL4Ui+aBiH73twhuSdGfsKh+AQ2aPZGcUzi2yP5UJL4UiuaBiH73uyMbKeHxo/AqI5fDYhtKlck8Slwl0Bz0zJ5YEyznh9dXvwCloIRxrQs1b9p+od0q5ZCX2xjbLEocHvPMeRqhezHz4UCHdFL/fQHO7/68UB7aqLxEb1mXQaZCUAqkvgA7Fcgt1vyi0l8VaJ5MKxpWSpF0zekV5pYlgnZvzujyDUK2W/Ctmmqsto//+BqAB/zD04M/fuN6rWnKwoTAl2SxAcgNy35JUl85aKxJL6wpmWpE83AkF5YEFTmsSgOqCDXbMh+6B4TXYd2JJWdLmpHVdnZB7ZP9Z+whzOqWdvtXyaJT7avwHPez+QHyybxLYgm7GlZ6kRjX2j1sN4qpXOZ7XyyHEP2l8jAgho/BeCTvrPaWdbjAL4VpmA2aHaj/yP/9ZX96j0KeLtlsm4Snx8lcFvY07JUiua003TgxArcwpD9ZSVgiz5/AWArTCacf4cpFOtrVMfPN1EIpDKJD3hIAG9K8k0l8Zlo5oHDYU/LUimasJ0ggf25nF/9gk4tEFylV62cxSoPkGWT+KYln6gkvtQuOSfQoaMccvX51eYXRwC8yP/b8tjGdPP1pd38yiQ+geyYh+T2yE47NitRhaJJlLk6Oth651c/5x/Sbme//bWVXjdodiQDTGhVEh8gewUnclOy64FW2o3DMxRNHKzQ2TH0+PeH1mu10fnVPwfwBT9r9S0uw7tMx88rlDYnK5L4BHhYS5uTd7q0F8e6FE0crdLemOxH/qsBfBDA0RpNNTq/2vZG7Jw3u+zKBGbL0vWLQsaQtTfL4nG7ZT+cQ92xbzTUdj+naNolGL/n7X94+9/87/5RU3+uMUQTQ73zq+0xi8v7LoCf1vuaozq+SSAmGIsyKC+7TiDj/UJ2piqJj6KJn9O3O6KLAPy6rJHNKGU+LlcanV/9AQC2l/JD/zqSijZKIfsFC8WvSOITYJ8i403LzlQm8VE07bpo/J4/e5ndfRON3YhQfbdoo/Or7ar4fwF4FYC/LXxVC9nPlMSyNIkPapuTqU7io2ji5/TtjigDwA5u/zGAW8sas+nau8ru37GPGp1fbXX6yw98rxey/xzg3Sf51CfxUTTtumg8n/+tLwi77t2uel9TY7rW9PnV9UL2eyDevXJH1yTxUTTxdPp2R/UjlK7+OAjgswA+U9WghavYZVU29bLFgJrFJWS/3UEn5XmKJimWchvnl/yg1Sv9adrXffF8tKyZP/l7KfZ3SWklZN9tiMmtTdEk13b1Rv4+AJYns6VqUWDKn7ZZJPhkrU1QC9kvBVZWJ/Hp9hU4XjNkP50ol34riiadlr7Ev1TXkssWih3RajFm9hZadrPyMs1uLJROtay6d6e5kP10oqRousWutsloeytv9Ve/6t5sYCH7FpqvbYbsdwtcvmnSaelX+oGWtsxsm5u/We5rXqXbVs7iidSE7IdlSoomLNLh9rMNwHH/OkT7u6TUC9lXrPCmZQfv3alhM4omXGeOvLfaIfu6NwN498ok791pYCWKJnI3DmcA9UP24U1LnvfuNGkKiqZJUImt1kUh+2HZiKIJi3QE/Yzqlk3AvP3Qr7x3B0hlyH5YiCmasEiH2E+tkH0F9kmKQ/bDQkzRhEU6hH5qh+zro/55YqkO2Q8BcbELiiYs0gH3w5D9gAGXNU/RhMc6kJ4Ysh8I1rqNUjThM+9IjyO6ZV0G8zVO2Rdvt9zBe3c6QnppIxRNQGCDarZeyL5AvCm5g/fuBAXfb5eiCRhwJ5uvFbIP4PZeHMvVOmW/k2NgW1wISIQPMGQ/XmbimyZe9qgYzQa95gK7HYwh+/EyEkUTL3sUR7NRr1t1DMftCvBUnLIfQ8RtDYmiaQtf5x+uH7J/3JuW7zNkv/PYnVqkaJxwBVe5Xsi+pSDvYch+cPAdW6ZoHIF1ujpD9jtNNPj2KJrgGS/fQ52Q/VKcWD4X1dDYb30CFE0EHrJBN48LCrabXxWyL3eegOTSdsp+BIgD7ZKiCRRvZeOjmr3Yv1W54pR9QB4A5nPTcmcqT9kPEXEoXVE0IWC+RDedvQIZu+yo6pR9huyHgL/jXVA0HUda2SBD9gMGHEHzFE1A0BmyHxDYGDRL0XTYCJfrlnXzxSvA9YqqpvcrGLLfYdyRNEfRdAi7hezbiphC7YqL8vKkQL0pmWTIfodYR90MRdMBC4xqdqvdalx9yj5D9jsAN4ZNUDRtGGVMx69UiK2KVZyyL8DdBWhut0zub6N5PhpTAhRNi4YZ1c0XAlotigMC5KYkbzeNsaSUAEXThmFHNWsXwW4V4BkFctOSv7mN5vhoQghQNG0Y6lK9bqAXx29RMGS/DYyJe5SiSZzJOOCoCVA0UVuA/SeOAEWTOJNxwFEToGiitgD7TxwBiiZxJuOAoyZA0URtAfafOAIUTeJMxgFHTYCiidoC7D9xBCiaxJmMA46aAEUTtQXYf+IIUDSJMxkHHDUBiiZqC7D/xBGgaBJnMg44agIUTdQWYP+JI0DRJM5kHHDUBCiaqC3A/hNHgKJJnMk44KgJUDRRW4D9J44ARZM4k3HAUROgaKK2APtPHAGKJnEm44CjJkDRRG0B9p84AhRN4kzGAUdNgKKJ2gLsP3EEKJrEmYwDjpoARRO1Bdh/4gj8H0PO0sVrUy0IAAAAAElFTkSuQmCC" %}
@hamelsmu hamelsmu added enhancement New feature or request help wanted Extra attention is needed labels Feb 18, 2020
@drscotthawley
Copy link
Contributor

I think now the plot.ly graphs might be working, and so a better title for this new Issue might be "Support for embedded image objects?" because that's the code that's getting rewritten into Liquid above.

@hamelsmu
Copy link
Member Author

@drscotthawley good point changing the title now

@hamelsmu hamelsmu changed the title Support For Plot.ly graphs? Support for embedded image objects Feb 18, 2020
@hamelsmu hamelsmu added the nbdev label Feb 18, 2020
@hamelsmu
Copy link
Member Author

This is the notebook that is causing the problem: https://github.com/drscotthawley/devblog2/blob/master/_notebooks/2020-02-18-fastpages_tests.ipynb

@hamelsmu
Copy link
Member Author

hamelsmu commented Feb 18, 2020

Here is the error I get. It makes sense. Thinking about a workaround. Have you tried to use a local image instead and see what happens?. Local image files don't work, I'll open an issue

image

@hamelsmu
Copy link
Member Author

Local image files don't work, I'll open an issue

@drscotthawley
Copy link
Contributor

Just a philosophy/opinion, and I know it's not my project so it's worth very little:
It'd be a shame to require people to manually sift through their notebooks and create local copies of their all their images in order to use fastpages, because then it'd be easier to just stick with Jupyter's own Export > HTML (like some of us who already have Jekyll/Pages blogs do), and skip fastpages entirely.
I suspect that Sylvain will come up with an nbdev hack that will fix this issue.
Otherwise we (including I) could create a way to automatically pull/render the problematic image objects and make local copies for them.

@hamelsmu
Copy link
Member Author

@drscotthawley that's true. I agree with you. I will try to find a way to support this with help from @sgugger

@drscotthawley
Copy link
Contributor

Hey one other piece of info/trivia I just learned, going back to the original title of this thread. No action required on your part, but this is an interesting FYI.

Turns out that plot.ly used to have some issues with nbformat when saving outputs in a notebook, so that it would give 'notebook verification' errors, and now it seems like those problems are back again (Plot.ly forum site).

So for any other people crazy enough to want to use plot.ly in their notebooks, they'll have to save the notebook without any of the plot.ly output in it. This is what Google Colab does by default, i.e. when you download an .ipynb file, any plot.ly output isn't included.

Then nbconvert and nbdev will add the plot.ly output javascript code, so that by the time it gets to Liquid... well yea that's when the conflicts with double-curly-braces start happening.

@hamelsmu
Copy link
Member Author

Embedded image objects work just tested this with nbdev. So do linked objects (they just don't work yet in fastpages until a new release is cut in pypi). Closing this issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed nbdev
Projects
None yet
Development

No branches or pull requests

2 participants