-
Notifications
You must be signed in to change notification settings - Fork 763
Support for embedded image objects #71
Comments
I think now the plot.ly graphs might be working, and so a better title for this new Issue might be "Support for embedded image objects?" because that's the code that's getting rewritten into Liquid above. |
@drscotthawley good point changing the title now |
This is the notebook that is causing the problem: https://github.com/drscotthawley/devblog2/blob/master/_notebooks/2020-02-18-fastpages_tests.ipynb |
Local image files don't work, I'll open an issue |
Just a philosophy/opinion, and I know it's not my project so it's worth very little: |
@drscotthawley that's true. I agree with you. I will try to find a way to support this with help from @sgugger |
Hey one other piece of info/trivia I just learned, going back to the original title of this thread. No action required on your part, but this is an interesting FYI. Turns out that plot.ly used to have some issues with So for any other people crazy enough to want to use plot.ly in their notebooks, they'll have to save the notebook without any of the plot.ly output in it. This is what Google Colab does by default, i.e. when you download an .ipynb file, any plot.ly output isn't included. Then nbconvert and nbdev will add the plot.ly output javascript code, so that by the time it gets to Liquid... well yea that's when the conflicts with double-curly-braces start happening. |
Embedded image objects work just tested this with nbdev. So do linked objects (they just don't work yet in fastpages until a new release is cut in pypi). Closing this issue |
See #66
Copy and pasting comment by @drscotthawley:
I found a tricky interaction between nbdev & the fastpages build.
nbdev is replacing "<img src=" HTML code with Liquid "{% img src" tags.
This might not be a problem ordinarily, but when running with Liquid in fastpages, it can't handle long "src" strings.
So here's a question for both @sgugger and @hamelsmu:
Would it be better to NOT have nbdev translate the HTML "img src" tags into Liquid, or would it be better to provide fastpage's Liquid run with...whatever it needs to handle long src strings?
The original HTML code in question:
This is getting converted by nbdev to
The text was updated successfully, but these errors were encountered: