Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: paged does not pass kwargs to operation #24

Closed
jrieke opened this issue Dec 20, 2020 · 2 comments · Fixed by #25
Closed

Bug: paged does not pass kwargs to operation #24

jrieke opened this issue Dec 20, 2020 · 2 comments · Fixed by #25
Labels
bug Something isn't working

Comments

@jrieke
Copy link
Contributor

jrieke commented Dec 20, 2020 •
edited
Loading

On this line, the kwargs that paged receives are not passed on to the operation (as is described in the docs here and the docstring in the line above).

This produces an error for me when using paged with a custom header, e.g.:

paged(api.activity.list_stargazers_for_repo, "fastai", "ghapi", headers={"Accept": "application/vnd.github.v3.star+json"})
@jrieke jrieke mentioned this issue Dec 20, 2020
Merged
@jrieke
Copy link
Contributor Author

jrieke commented Dec 20, 2020

Made a small PR to fix this, see #25

@hamelsmu hamelsmu added the bug Something isn't working label Dec 28, 2020
@hamelsmu
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass kwargs to operation in paged jrieke/ghapi
2 participants
@hamelsmu @jrieke