-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest release breaks command #hide_input
#105
Comments
P.S. this looks like the breaking commit 49d8715 I would make a PR to fix, but I'm not 100% sure regarding the intended use cases that regex is supposed to cover. |
I know what the problem is, will fix once the kids give me a break ;) |
Should be fixed and I added a test. Can you confirm the problem is solved? Then I'll cut a new release. |
Yeah give me a couple of hours, things are really crazy in my house 🙇 |
@sgugger I have tested this and you can safely cut a new release now. 🙇 HOWEVER, I have noticed that the versions in pypi and this repo are not aligned. For example the highest version in this repo is P.S. I'm happy to assist with automation around this with GitHub Actions and releases if this could be useful. |
Yes the version on GitHub is always one more than pypi: that's because master is the new version development. |
Ahhh makes sense |
Release done :) |
Im still struggling with this on |
Before
0.2.14
the comment#hide_input
would hide input onlyNow, with release
0.2.14
the comment#hide_input
hides BOTH the input and the output.I believe this is a bug? Or has this functionality been changed? @sgugger
Thank you!
The text was updated successfully, but these errors were encountered: