Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release breaks command #hide_input #105

Closed
hamelsmu opened this issue Mar 18, 2020 · 9 comments
Closed

Latest release breaks command #hide_input #105

hamelsmu opened this issue Mar 18, 2020 · 9 comments

Comments

@hamelsmu
Copy link
Member

hamelsmu commented Mar 18, 2020

Before 0.2.14 the comment #hide_input would hide input only

Now, with release 0.2.14 the comment #hide_input hides BOTH the input and the output.

I believe this is a bug? Or has this functionality been changed? @sgugger

Thank you!

@hamelsmu
Copy link
Member Author

P.S. this looks like the breaking commit 49d8715

I would make a PR to fix, but I'm not 100% sure regarding the intended use cases that regex is supposed to cover.

@sgugger
Copy link

sgugger commented Mar 18, 2020

I know what the problem is, will fix once the kids give me a break ;)

@sgugger
Copy link

sgugger commented Mar 18, 2020

Should be fixed and I added a test. Can you confirm the problem is solved? Then I'll cut a new release.

@hamelsmu
Copy link
Member Author

Yeah give me a couple of hours, things are really crazy in my house 🙇

@hamelsmu
Copy link
Member Author

@sgugger I have tested this and you can safely cut a new release now. 🙇 HOWEVER, I have noticed that the versions in pypi and this repo are not aligned.

For example the highest version in this repo is 0.2.15 however the same release on pypi is on 0.2.14, so version numbers may be mismatched?

P.S. I'm happy to assist with automation around this with GitHub Actions and releases if this could be useful.

@sgugger
Copy link

sgugger commented Mar 18, 2020

Yes the version on GitHub is always one more than pypi: that's because master is the new version development.

@hamelsmu
Copy link
Member Author

Ahhh makes sense

@sgugger
Copy link

sgugger commented Mar 18, 2020

Release done :)

@dsm-72
Copy link
Contributor

dsm-72 commented Mar 12, 2023

Im still struggling with this on v2 is this just #| hide_input (tried this), #hide_input (tried this first, failed to hide it), or #|echo: false? they all yield the input...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants