Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Poetry 1.2.x release #21

Closed
3 of 4 tasks
rszamszur opened this issue Jan 21, 2022 · 3 comments · Fixed by #142
Closed
3 of 4 tasks

Migrate to Poetry 1.2.x release #21

rszamszur opened this issue Jan 21, 2022 · 3 comments · Fixed by #142
Assignees
@rszamszur
Labels
enhancement New feature or request

Comments

@rszamszur
Copy link
Member

rszamszur commented Jan 21, 2022 •
edited
Loading

The get-poetry.py script will be replaced in Poetry 1.2 by install-poetry.py.

Moreover, some additional adjustments will be needed in order to accommodate to new minor version:

  • Change default $POETRY_HOME to $HOME/.local/share/pypoetry in all relevant files (make scripts, Dockerfiles, nix shell expressions).
  • Change absolute path to poetry executable to: $POETRY_HOME/venv/bin/poetry
  • Update install scripts with install-poetry.py URL.
  • Update Poetry config in GitHub workflows

The above applies to both package (fastapi-mvc) and template.
@rszamszur rszamszur added the enhancement New feature or request label Jan 21, 2022
@rszamszur rszamszur mentioned this issue Jan 21, 2022
Closed
4 tasks
@rszamszur rszamszur added blocked Issue is blocked at the moment good first issue Good for newcomers labels Jan 21, 2022
@rszamszur
Copy link
Member Author

For now, blocked. Awaiting Poetry 1.2.0 release.

@rszamszur
Copy link
Member Author

Default poetry home, will need to be updated here as well:

https://github.com/rszamszur/fastapi-mvc/blob/9ec7ecf532b77f2b38c3f1e6d9fd299f500c7158/fastapi_mvc/borg.py#L101-L103

@rszamszur rszamszur removed the good first issue Good for newcomers label Apr 24, 2022
@rszamszur rszamszur mentioned this issue Apr 24, 2022
Closed
1 task
@rszamszur rszamszur mentioned this issue Jun 29, 2022
Closed
@rszamszur
Copy link
Member Author

Poetry 1.2.0 is officially released.

@rszamszur rszamszur removed the blocked Issue is blocked at the moment label Sep 12, 2022
@rszamszur rszamszur self-assigned this Sep 12, 2022
@rszamszur rszamszur mentioned this issue Sep 13, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rszamszur rszamszur

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve project automation and migrate to Poetry 1.2.x release fastapi-mvc/fastapi-mvc
1 participant
@rszamszur