Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/improve project template structure #90

Closed
1 task done
rszamszur opened this issue Apr 25, 2022 · 1 comment · Fixed by #99
Closed
1 task done

Refactor/improve project template structure #90

rszamszur opened this issue Apr 25, 2022 · 1 comment · Fixed by #99
Assignees
Labels
copier: project Related to copier template refactor Related to major code refactoring/reorganisation
Milestone

Comments

@rszamszur
Copy link
Member

  • I have searched the issues of this repo and believe that this is not a duplicate.

Feature Request

Small refactor for generated project from the template:

  1. Technically JSON Responses (pydantic models) are Views in MVC, and should be kept accordingly to avoid confusion.
  2. IMHO, .app.controllers.api.v1 submodule nesting is a bit excessive. Either .app.controllers or .app.controllers.v1 will be enough.
@rszamszur rszamszur added copier: project Related to copier template refactor Related to major code refactoring/reorganisation labels Apr 25, 2022
@rszamszur rszamszur added this to the 0.12.0 milestone Apr 27, 2022
@rszamszur rszamszur self-assigned this Apr 27, 2022
@rszamszur
Copy link
Member Author

rszamszur commented May 10, 2022

Changed coociecutter options:

  • removed --skip-vagrantfile
  • removed --skip-codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
copier: project Related to copier template refactor Related to major code refactoring/reorganisation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant