New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Formatting notebooks #73
Conversation
…C50. Before, as both were master.zip, they would overwrite each other.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
The rules for the toc rendering correctly are the follow: |
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
- Coverage 90.88% 90.57% -0.31%
==========================================
Files 12 12
Lines 647 647
Branches 70 70
==========================================
- Hits 588 586 -2
- Misses 32 34 +2
Partials 27 27
Continue to review full report at Codecov.
|
🎉 This PR is included in version 0.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This pull request has the objective to clean small formatting problems on the tutorial notebooks so they render better on the docs page, and also remove some references to things from fastai v1 that don't make sense anymore, like using the full 10 speakers dataset when we only need one audio file.
The only code change was updating the link of 10 speakers sample. As both it and ESC-50 downloaded a file called master.zip, there could be problems where both files got mixed in the fastai cache and you end up with the wrong dataset.
For the notebook changes:
ESC-50:
* Removed empty cells
* Save output of show_batch and the training so users know what to expect while reading the tutorial
* Fix headings so Table of Contents is rendered correctly
Training tutorial:
* Removed, it's exactly the same file as ESC50
Introduction to fastaudio:
* Change data to 10 speakers sample from full 10 speakers
Introduction to audio:
* Removed Table of contents, as the docs page creates one
* Fix headings
* Remove reference to notebooks that don't exist
* Change data to 10 speakers sample from full 10 speakers