Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observations with string/boolean Values display as blank in Charts and fhir-card #360

Closed
Royal2000H opened this issue Dec 13, 2023 · 3 comments · Fixed by #453
Closed

Observations with string/boolean Values display as blank in Charts and fhir-card #360

Royal2000H opened this issue Dec 13, 2023 · 3 comments · Fixed by #453
Assignees

Comments

@Royal2000H
Copy link

Just set up Fasten and playing around with it with real data.

It appears the non-numeric results just show as

"Result: " (just blank)

If I go into the observation and then debug, it does show results such as:
"valueString": "NONREACTIVE" or "valueString": "NEGATIVE" or "valueString": "NOT DETECTED"

@AnalogJ AnalogJ changed the title Results with strings display as blank Observations with string/boolean Values display as blank in Charts and fhir-card Dec 13, 2023
@AnalogJ
Copy link
Member

AnalogJ commented Dec 13, 2023

Ah thanks for calling this out. I had seen it previously but it slipped my mind.

I had been focused on graphing numerical Observations, but boolean (and string) values require some additional work to display and compare correctly.

@AnalogJ
Copy link
Member

AnalogJ commented Mar 8, 2024

related #441
related #440

@AnalogJ
Copy link
Member

AnalogJ commented Mar 8, 2024

From my discussion with @jean-the-coder on Discord:

They're all kind of related to the fact that Fasten only handles numerical values for lab results at the moment, because I display everything on a graph. Anything that's not a number is ignored by chartjs I think.

A simple workaround for now might just be to display a table of values if any of the lab results is a string.

https://github.com/fastenhealth/fasten-onprem/blob/main/frontend/src/app/components/report-labs-observation/report-labs-observation.component.html#L56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants