Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rundir = "." should not be required for IT tests #5

Open
apesternikov opened this issue Aug 21, 2023 · 0 comments
Open

rundir = "." should not be required for IT tests #5

apesternikov opened this issue Aug 21, 2023 · 0 comments

Comments

@apesternikov
Copy link
Contributor

currently the canonical way for IT tests to locate the setup binary is through

data = [
   ":target_it.setup"
],
args = [
   "-setup",
   "$(location :target_it.setup")",
],

which also require

rundir = "."

in go tests because the default current working dir for go tests is the test source directory to be compatible with the non-bazel way of running tests.
IT setup target should be able to locate runfiles if test is started with or without rundir parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant