Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demote StreamReadConstraints further down parser inheritance hierarchy #1304

Closed
cowtowncoder opened this issue Jun 12, 2024 · 0 comments
Closed

Demote StreamReadConstraints further down parser inheritance hierarchy #1304

cowtowncoder opened this issue Jun 12, 2024 · 0 comments
Labels
2.18 Issues planned at earliest for 2.18

Comments

@cowtowncoder
Copy link
Member

Currently (pre-2.18), StreamReadConstraints is a field of ParserBase and not ParserMinimalBase.
But for various reasons, it'd be better if it was actually moved down (demoted) to ParserMinimalBase.
This seems doable, for 2.18 and should not cause backwards compatibility issues with non-JSON implementations.

This would be useful in particular for #1296 to have direct access during construction.
@cowtowncoder cowtowncoder added the 2.18 Issues planned at earliest for 2.18 label Jun 12, 2024
cowtowncoder added a commit that referenced this issue Jun 13, 2024
@cowtowncoder
Fix #1304: demote StreamReadConstraints from ParserBase to ParserMini…
25c787d 
…malBase
cowtowncoder added a commit that referenced this issue Jun 13, 2024
@cowtowncoder
One addition to #1304
54429af
@pjfanning pjfanning mentioned this issue Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.18 Issues planned at earliest for 2.18
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cowtowncoder