Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.16 jackson-databind deserialization changes have broken support for the scala.util.Either class #649

Closed
pjfanning opened this issue Oct 7, 2023 · 1 comment

Comments

@pjfanning
Copy link
Member

pjfanning commented Oct 7, 2023

see FasterXML/jackson-databind#4147

https://github.com/FasterXML/jackson-module-scala/actions/runs/6442522651/job/17493416303

The issue also now affects master branch but not the 2.15 branch.

Scala 2.13 is less affected than Scala 2.11/2.12 and Scala 3. The classes generated by Scala 2.13 compiler may not expose the wildcards. The deserialization issues affect types like Either[_, String] - in this case the user expects the result to be a Right so they don't provide an explicit type for the Left. This is a real edge case and something that I wouldn't encourage users to do. We have tests that do this but it was probably just a convenience for the person writing the tests.

@pjfanning pjfanning changed the title 2.16 jackson-databind deserializtion changes have broken support for the scala.util.Either class 2.16 jackson-databind deserialization changes have broken support for the scala.util.Either class Oct 7, 2023
@pjfanning
Copy link
Member Author

pjfanning commented Oct 13, 2023

jackson-databind changes that caused this were reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant