Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tilix terminal font detection fails #39

Closed
DarNCelsius opened this issue May 13, 2021 · 4 comments · Fixed by #40
Closed

Tilix terminal font detection fails #39

DarNCelsius opened this issue May 13, 2021 · 4 comments · Fixed by #40
Labels
bug Something isn't working

Comments

@DarNCelsius
Copy link
Contributor

Terminal font recognition for Tilix fails in r264:
tilixtfbug
As you can see, It works in r256.

Both system and custom font detection fails.

@DarNCelsius
Copy link
Contributor Author

A lot of changes to settings.c between these versions. I suspect it's in the DConf implementation:
tilixtfbug2

@LinusDierheimer
Copy link
Collaborator

You know better how the Tilix code works, can you try to fix it please?

@DarNCelsius
Copy link
Contributor Author

It looks like this is NULL at line 60 in settings.c:

    if(data->client == NULL)
        return FF_VARIANT_NULL;

Is DConf not loading properly?

@DarNCelsius
Copy link
Contributor Author

Yup. Replacing this line:

DynamicLibrary library = FF_LIBRARY_LOAD(instance->config.libDConf, "libdocnf.so", mutex);

with this from 256:

    void* library = dlopen(instance->config.libDConf.length == 0 ? "libdconf.so" : instance->config.libDConf.chars, RTLD_LAZY);
    if(library == NULL)
    {
        pthread_mutex_unlock(&mutex);
        return FF_VARIANT_NULL;
    }

makes it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants