Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please bundle Apache 2.0 license in the releases as the license requires #201

Closed
vlsi opened this issue May 8, 2023 · 2 comments
Closed

Comments

@vlsi
Copy link

vlsi commented May 8, 2023

The license requires to give a copy of the license when redistributing the software:

See https://www.apache.org/licenses/LICENSE-2.0
4.a You must give any other recipients of the Work or Derivative Works a copy of this License; and

Even though fast_float.h in the releases includes a link to http://www.apache.org/licenses/LICENSE-2.0, the link is not a copy as the link might become inaccessible, so the recipients might fail to receive "a copy of the License".

Ideally, the full text of Apache-2.0 should be included in fast_float.h as it seems to be "single-file release artifact" (10KiB license vs 110KiB implementation).

As an alternative, it might work if you add a separate LICENSE with full Apache-2.0 text side by side with fast_float.h in the releases.

Just in case, here's the opinion of the Apache Software Foundation: https://issues.apache.org/jira/browse/LEGAL-642

@vlsi vlsi changed the title Please bundle Apache 2.0 license as the license requires Please bundle Apache 2.0 license in the releases as the license requires May 8, 2023
@lemire
Copy link
Member

lemire commented May 8, 2023

Pull request invited.

@lemire
Copy link
Member

lemire commented May 8, 2023

The release do include the APACHE license. If you think there is an issue, please produce a pull request.

@lemire lemire closed this as completed May 8, 2023
@fastfloat fastfloat locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants