Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename thompson_tao.h to simple_decimal_conversion.h. #7

Closed
lemire opened this issue Oct 24, 2020 · 2 comments · Fixed by #13
Closed

Rename thompson_tao.h to simple_decimal_conversion.h. #7

lemire opened this issue Oct 24, 2020 · 2 comments · Fixed by #13

Comments

@lemire
Copy link
Member

lemire commented Oct 24, 2020

cc @nigeltao
@lemire
Copy link
Member Author

lemire commented Oct 27, 2020 •
edited

Fixing via https://github.com/lemire/fast_float/pull/13

@lemire lemire mentioned this issue Oct 27, 2020
Merged
@lemire
Copy link
Member Author

lemire commented Oct 27, 2020

Note that I still credit @nigeltao because I mostly copied his C code, while changing the style (making it C++ like). This change leaves the credit for the algorithm itself more vague, which is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing issue 7 (renaming fallback) fastfloat/fast_float
1 participant
@lemire