Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any plan to support websocket client of fasthttp? #36

Closed
Quons opened this issue Apr 9, 2023 · 5 comments
Closed

Is there any plan to support websocket client of fasthttp? #36

Quons opened this issue Apr 9, 2023 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Quons
Copy link

Quons commented Apr 9, 2023

I am focus on a websocket proxy gateway works,so i need both server and client of websocket. but i notidy that this project support only server side of websocket base on fasthttp,is there any plan to support the client side ?

@savsgio
Copy link
Member

savsgio commented Apr 12, 2023

Hi @Quons,

I don't rule it out, but for now, i don't have to much time to add support to the client.
So, if you need it, a PR is welcome! 😉

@savsgio savsgio added enhancement New feature or request help wanted Extra attention is needed labels May 16, 2023
@g41797
Copy link

g41797 commented May 20, 2023

Hi
As far as i understand , websocket client (fork of gorilla...) is part of this project and everyone can use it ,
savsgio - please confirm

@joeky888
Copy link

joeky888 commented Jun 1, 2023

I can confirm fasthttp websocket client with http proxy works. Tested with https://github.com/joeky888/fpgo

dialer := websocket.Dialer{
	Proxy: http.ProxyURL(&url.URL{
		Scheme: "http", // or "https" depending on your proxy
		Host:   "127.0.0.1:13002",
		Path:   "/",
	}),
}

c, _, err := dialer.Dial("wss://ws.bitget.com/mix/v1/stream", nil)
if err != nil {
	log.Fatal("dial:", err)
}
defer c.Close()

I guess we can close this issue, unless I missed something.

@g41797
Copy link

g41797 commented Jun 2, 2023

you did

fasthttp/websocket is fork of non-maintained gorilla/websocket
gorilla/websocket has 28 opened issues and 12 PRs

  • "what about unresolved issues and PRs?"
  • "are you going to announce fasthttp as new maintainer of websocket?"

@savsgio
Copy link
Member

savsgio commented Jul 18, 2023

Hi @g41797 and @joeky888,

I'm trying to maintain the fork as much I can. So if you need to resolve some issue from gorilla project and it be here, you can make a PR about it or create an issue here to try to fix it.

PR are always welcome. 😉

Thank you so much! And sorry for my delayed answer!

@savsgio savsgio closed this as completed Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants