Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is node v6.11.3 supported? #16

Closed
jpwesselink opened this issue Sep 11, 2017 · 4 comments
Closed

Is node v6.11.3 supported? #16

jpwesselink opened this issue Sep 11, 2017 · 4 comments
Assignees
Labels
bug Confirmed bug

Comments

@jpwesselink
Copy link

I tried to run benchmark on node-v6.11.3, and it seems that it needs async to work properly.

$ node -v
v6.11.3
$ npm -v
3.10.10
$ benchmark 
/usr/local/lib/node_modules/fastify-benchmarks/lib/bench.js:7
const doBench = async (handler) => {
                      ^

SyntaxError: Unexpected token (

@cagataycali
Copy link
Contributor

Ah, benchmarks depends async capability node 6.x isn't support for now

@cagataycali cagataycali self-assigned this Sep 11, 2017
@cagataycali cagataycali added the bug Confirmed bug label Sep 11, 2017
@cagataycali
Copy link
Contributor

@delvedor, should we support node 6.x?

@delvedor
Copy link
Member

Node v6 is the currently LTS and will also be used later when Node v8 will be the new LTS.
So in my opinion yes, we should support Node v6.
@mcollina?

@mcollina
Copy link
Member

Node 8 will become active LTS by the end of October. Node 6 will remain active LTS until April 2018, and then go into maintenance.

I do not have a problem in using Node 8 for the time being for these benchmarks, as I just need to run them on Node 8. However, others might want to run this harness on Node 6 as well. I'm ok with that, if someone wants to do the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

4 participants