Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI for pull requests #57

Closed
dougwilson opened this issue May 21, 2018 · 1 comment
Closed

Setup CI for pull requests #57

dougwilson opened this issue May 21, 2018 · 1 comment

Comments

@dougwilson
Copy link
Contributor

There is a npm test script included in the module. Can someone with privileges set this up in CI so the result shows in pull requests?

It currently fails because no one realized that some PRs were not passing before merging because there is no CI.

$ npm test

> fastify-benchmarks@0.3.4 test /Users/doug.wilson/Code/NodeJS/fastify-benchmarks
> standard | snazzy

standard: Use JavaScript Standard Style (https://standardjs.com)
standard: Run `standard --fix` to automatically fix some problems.

/Users/doug.wilson/Code/NodeJS/fastify-benchmarks/benchmark-bench.js
  92:1  error  Expected indentation of 4 spaces but found 2
  93:1  error  Expected indentation of 6 spaces but found 4
  94:1  error  Expected indentation of 4 spaces but found 2

/Users/doug.wilson/Code/NodeJS/fastify-benchmarks/benchmarks/@leizm-web.js
  3:46  error  Extra semicolon
  5:26  error  Extra semicolon

/Users/doug.wilson/Code/NodeJS/fastify-benchmarks/benchmarks/trek-engine-router.js
  26:7   error  Expected literal to be on the right side of ==
  26:11  error  Expected '===' and instead saw '=='

/Users/doug.wilson/Code/NodeJS/fastify-benchmarks/benchmarks/trek-engine.js
  15:7   error  Expected literal to be on the right side of ==
  15:11  error  Expected '===' and instead saw '=='

✖ 9 problems
npm ERR! Test failed.  See above for more details.
@delvedor
Copy link
Member

Hi! Thank you for pointing this out!
I'll enable travis :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants