Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a benchmark to techempower.com #65

Closed
styfle opened this issue Jul 9, 2018 · 6 comments
Closed

Consider adding a benchmark to techempower.com #65

styfle opened this issue Jul 9, 2018 · 6 comments

Comments

@styfle
Copy link

styfle commented Jul 9, 2018

This website compares many web server frameworks and it might be useful to add fastify to this benchmark if it performs better than the node.js core http module.

https://www.techempower.com/benchmarks

@aichholzer
Copy link
Contributor

Those benchmarks are anything but accurate. They compare apples to oranges and there is no point to get into those numbers/metrics.

@styfle
Copy link
Author

styfle commented Jul 9, 2018

Why do you say that? Can you elaborate?

@Nepoxx
Copy link

Nepoxx commented Oct 26, 2018

@aichholzer I wouldn't mind getting Fastify on there for you unless you have strong objections?

@aichholzer
Copy link
Contributor

@Nepoxx -No objections at all, I maintain this repository, not my call to object or not. Speaking of which and to answer @styfle question; the techempower benchmarks are, IMO, nothing to go by as they do not compare things on a "fair" basis, meaning they do compare all sorts of frameworks for the sake of speed. Having that said, you cannot compare C++ to Nodejs or stuff that uses multi-core, by default, against stuff that does not.

Having that said, @Nepoxx feel free to PR Fastify into it (techempower).

@Nepoxx
Copy link

Nepoxx commented Oct 29, 2018

Alright I'll do that.

By the way, the techempower benchmarks, while not perfect, do account for multithreading as the node examples use the cluster module. Its really up to the people writing the benchmarks to account for it (and other things).

@aichholzer
Copy link
Contributor

Alright, thank you.
I am aware of the cluster, nonetheless it is still does not seem like a fair/good comparison in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants