Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Content-Encoding handled gracefully? #62

Closed
2 tasks done
Uzlopak opened this issue Dec 3, 2021 · 2 comments
Closed
2 tasks done

Is Content-Encoding handled gracefully? #62

Uzlopak opened this issue Dec 3, 2021 · 2 comments

Comments

@Uzlopak
Copy link
Contributor

Uzlopak commented Dec 3, 2021

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

mscdex/busboy#150
expressjs/multer#976

It was reported, that busboy breaks "silently" if payload is sent as gzip encoded. I dont think that we should handle gzip or any other content-encoding in busboy.

But we should check what "silently" means. Does it crash the server? Does it not throw any error?
For this we would need some payload to test with. @wenjunche can you please provide a complete payload to see what is happening?
Also we should consider to document that busboy does not handle content-encoding and use the "workaround" as solution .

@Uzlopak Uzlopak closed this as completed Dec 20, 2021
@kibertoad
Copy link
Member

@Uzlopak What's the takeaway?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Dec 20, 2021

In multer they suggest @wenjunche he should provide a PR to our repo. We should wait if he does so. No need to keep it track twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants