-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone mode doesn't work without dependencies #552
Comments
I believe the statement in |
Maybe it's better to reexport them somehow from fjs, so user will have to install and require only fjs. WDYT? |
If the dependency is imported from |
Sorry, I didn't get you. |
It means that if I want to compile the |
FJS is a small module. I think the main goal of standalone mode is to reduce compilation time but not the size. |
Valid point, but the movement just reduce a valid use-case that currently support. |
It’s very inconvenient right now. I can’t just update to the new FJS version and recompile. I have to go and check docs or check source code in order to be sure that there is no new dependencies appeared. It may break someone prod if he didn't check it. |
I am not block to either |
I'm -1 to bundle the dependencies. In the standalone code, we could |
Cant we use peerDependencies? |
They won't do if the goal is to have a standalone build that could be run without having fjs in the dependency tree. |
Prerequisites
Issue
Standalone mode is not working without required deps:
ajv
,fast-uri
,ajv-formats
,rfdc
. Should we use webpack to create a bundle or it's ok?The text was updated successfully, but these errors were encountered: