Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to svelte v4 #105

Open
2 tasks done
Uzlopak opened this issue Aug 7, 2023 · 3 comments
Open
2 tasks done

Update to svelte v4 #105

Uzlopak opened this issue Aug 7, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 7, 2023

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

Currently the svelte dependabot PR is failing, because svelte dropped cjs support in v4.

We should adapt our code for the example, so that our unit tests work.
Or report, that it is not possible and we should consider either changing svelte with a different framework or reject upgrading svelte.

@Uzlopak Uzlopak added the good first issue Good for newcomers label Aug 7, 2023
@lmauromb
Copy link
Contributor

lmauromb commented Dec 9, 2023

hey @Uzlopak will it be viable to replace with point-of-view ?

I'm experimenting with a replacement using Handlebars, but I was thinking that maybe using Hotwire with point-of-view makes a lot of sense.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Dec 9, 2023

@lmauromb
I cant give any qualified answer because I do not use this package.
I personally dont like handlebars, because most templatung can be done with string template literals.

@lmauromb
Copy link
Contributor

@Uzlopak thanks for the update!

let me look at different alternatives to either update the example code to mjs so the svelte template works again or use an alternate templating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants