Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi 3.1 support #67

Closed
2 tasks done
maxgurewitz opened this issue May 30, 2023 · 6 comments
Closed
2 tasks done

openapi 3.1 support #67

maxgurewitz opened this issue May 30, 2023 · 6 comments

Comments

@maxgurewitz
Copy link

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

Hi all. This project doesn't seem to support openapi 3.1.

Screen Shot 2023-05-29 at 10 13 17 PM

However swagger-ui seems to support openapi 3.1.

https://github.com/swagger-api/swagger-ui/pull/8367/files

Is addressing this easy? Thank you.

Motivation

No response

Example

No response

@Uzlopak
Copy link
Collaborator

Uzlopak commented May 30, 2023

Well you could just patch the version check, but we need to check what the differences are and maybe see if the new features are handled properly.

@mcollina
Copy link
Member

mcollina commented Jun 5, 2023

We should update to swagger-ui v5, but I'm not sure this was released yet.

@qqilihq
Copy link

qqilihq commented Jun 12, 2023

Swagger UI 5.0.0 is available since a few hours.

We've already been using a patched fastify-swagger-ui library during the last few weeks, as we needed OpenAPI 3.1 support. This worked well for us. In case anybody is interested for the time being, I've just updated it to use the final swagger-ui v5.0.0

NPM: @lineupr/fastify-swagger-ui
GitHub: https://github.com/LineUpr/fastify-swagger-ui

@Uzlopak
Copy link
Collaborator

Uzlopak commented Jun 13, 2023

@qqilihq

Ok, dependabot merged automatically swagger-ui. Does anything needs to be patched?

@qqilihq
Copy link

qqilihq commented Jun 13, 2023

@Uzlopak Just changing to "swagger-ui-dist": "5.0.0" was sufficient for us. (diff)

@mcollina
Copy link
Member

I've just shipped v1.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants