Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 2.3.0 not building #46

Closed
2 tasks done
davidmeirlevy opened this issue Nov 21, 2021 · 4 comments
Closed
2 tasks done

[Bug] 2.3.0 not building #46

davidmeirlevy opened this issue Nov 21, 2021 · 4 comments

Comments

@davidmeirlevy
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Fastify version

3.23.1

Plugin version

2.3.0

Node.js version

14.7 + 15.x

Operating system

Linux

Operating system version (i.e. 20.04, 11.3, 10)

tried on mac, linux (both github actions and circleci)

Description

Running node index.ms build is running the server and doesn't generate the dist directory.

Steps to Reproduce

  1. use 2.2.4 - run node index.ms build - will work.
  2. re-install the plugin at version 2.3.0 - fastify server will run, dist folder will not be created

Expected Behavior

dist folder should be created with relevant files, and the process should be exited with code 0.

@galvez
Copy link
Member

galvez commented Nov 21, 2021

Did you see the release notes for v2.3.0? There's a breaking change related to it.

@davidmeirlevy
Copy link
Collaborator Author

@galvez I have 2 branches that the only difference between them is the version of fastify-vite.
this one has 2.2.4:
greenpress/greenpress#135 (it's a monorepo, so look for apps/front-ssr).

the second with version 2.3.0:
greenpress/greenpress#137 (same folder).

@davidmeirlevy
Copy link
Collaborator Author

Did you see the release notes for v2.3.0? There's a breaking change related to it.

no, I didn't... you just release 2.2.4 yesterday, so I haven't figured out there are so many publishes until today :)

@davidmeirlevy
Copy link
Collaborator Author

davidmeirlevy commented Nov 21, 2021

@galvez looks like it's working after i changed await app.vite.ready() to: await app.vite.commands() on the index.mjs.
I'll wait for circleci + github actions results.

update: yes it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants