next and 1.x branch is currently failling CI build

[Ethan-Arrowood]

See this manual pipeline execution: https://dev.azure.com/fastify/fastify/_build/results?buildId=1699&view=results

The error is TypeScript related: https://dev.azure.com/fastify/fastify/_build/results?buildId=1699&view=logs&j=bf7c6fb2-34e3-5d65-0f4a-49158f2ba27b&t=3357be4a-1360-5b27-f34e-4cd70356d9a8&l=8278

test/types/index.ts(247,13): error TS2345: Argument of type 'RouteShorthandOptions<Http2Server, Http2ServerRequest, Http2ServerResponse, DefaultQuery, DefaultParams, DefaultHeaders, any>' is not assignable to parameter of type 'RouteShorthandOptions<Http2SecureServer, Http2ServerRequest, Http2ServerResponse, DefaultQuery, DefaultParams, DefaultHeaders, any>'.

Self assigning. Will fix this asap (also investigating stability of 1.x)
Property 'addContext' is missing in type 'Http2Server' but required in type 'Http2SecureServer'.

[Ethan-Arrowood]

@fastify/core pinging core team to be aware of this. Both errors are the same. Manual CI builds for both 1.x and next branches can be found below.

• 1.x
• next

[Ethan-Arrowood]

😕 Looks like master is also failing because of this TypeScript issue: https://dev.azure.com/fastify/fastify/_build/results?buildId=1702&view=results

I have class for another hour then I'll be able to investigate this. I'm worried as to why this wasn't caught before

[Ethan-Arrowood]

Replicate by:

• Locally pull any of 3 main branches
• Clear node_modules and run npm install
• Run npm run typescript

[Ethan-Arrowood]

This commit to @types/node may be the cause of the issue: DefinitelyTyped/DefinitelyTyped@2bc4577

Regardless, I believe the fix will come as a type update on our end.

[Ethan-Arrowood]

PRs open for all branches. CI is running for all of them as well 😄

Crossing my fingers that everything passes. After that some rebasing will need to be done on my other open prs and we can start getting stuff merged and closed 😄