Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should test if destroy is a function #2928

Merged
merged 1 commit into from
Mar 10, 2021
Merged

fix: should test if destroy is a function #2928

merged 1 commit into from
Mar 10, 2021

Conversation

nicolashenry
Copy link
Contributor

Ref: #2915 (comment)

Checklist

L2jLiga
L2jLiga approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@L2jLiga L2jLiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a25e836 into fastify:master Mar 10, 2021
This was referenced Mar 11, 2021
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Closed
This was referenced Mar 12, 2021
Closed
Closed
Closed
Merged
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@L2jLiga L2jLiga L2jLiga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolashenry @mcollina @L2jLiga