Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to pino@7 when it is available #3101

Closed
mcollina opened this issue May 26, 2021 · 10 comments
Closed

Update to pino@7 when it is available #3101

mcollina opened this issue May 26, 2021 · 10 comments
Assignees
@kibertoad
Labels
feature request New feature to be added semver-major Issue or PR that should land as semver major v4.x Issue or pr related to Fastify v4
Milestone
v4.0.0

Comments

@mcollina
Copy link
Member

Update to pino@7 when it is available.

This issue is a requirement for v4.
@mcollina mcollina added semver-major Issue or PR that should land as semver major feature request New feature to be added labels May 26, 2021
@mcollina mcollina added this to the v4.0.0 milestone May 26, 2021
@mcollina
Copy link
Member Author

@kibertoad would you like to take this on as it would require some fundamental rework of the typescript types?

@mcollina
Copy link
Member Author

Pino v7.0.0-rc.1 just shipped, release notes in https://github.com/pinojs/pino/releases/tag/v7.0.0-rc.1

@kibertoad
Copy link
Member

@mcollina With pleasure. Should I target next?

@mcollina
Copy link
Member Author

@mcollina With pleasure. Should I target next?

yes exactly!

@kibertoad kibertoad self-assigned this Jul 21, 2021
@mcollina
Copy link
Member Author

mcollina commented Aug 9, 2021

@kibertoad any updates on this?

@kibertoad
Copy link
Member

@mcollina yeah, will work on it this week, it was a pre-vacation crunch before. Sorry for the delay.

@mcollina
Copy link
Member Author

mcollina commented Aug 9, 2021

No worries, just a status check

@climba03003 climba03003 added the v4.x Issue or pr related to Fastify v4 label Aug 16, 2021
This was referenced Aug 26, 2021
Merged
Merged
@kibertoad
Copy link
Member

Blocked until 7.0.0-rc.4 is released.

@climba03003
Copy link
Member

climba03003 commented Sep 3, 2021 •
edited

Blocked until 7.0.0-rc.4 is released.

I think we can target to github:pinojs/pino until pino release a stable 7.0.0 version.

@kibertoad
Copy link
Member

This is done. We will just need to update to pino 7 final when it is available.

@RaenonX RaenonX mentioned this issue Sep 11, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kibertoad kibertoad

Labels
feature request New feature to be added semver-major Issue or PR that should land as semver major v4.x Issue or pr related to Fastify v4
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
3 participants
@mcollina @kibertoad @climba03003